[jbosstools-issues] [JBoss JIRA] (JBIDE-25901) MINISHIFT_HOME is not propagated to new detected cdk binary properly

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556157#comment-13556157 ] 

Rob Stryker commented on JBIDE-25901:
-------------------------------------

a server adapter needs 2 things really:   1) minishift binary location,  and 2) a minishift_home 

if a user makes a runtime detection path of /home/user/some_minishift_home,   then my runtime detection will use that minishift_home when creating the server adapter. We will then try to find a minishift binary somewhere, to create the server adapter

however, if a user makes a runtime detection path of /home/user/apps/cdk32  which has a valid cdk / minishift binary inside it,    then we have the binary, and we need to find a minishift_home for it 

if 4 server adapter are all using the same minishift_home,  it will get corrupted. you cant have 4 different versions of something using the same minishift_home . its a recipe for it to get corrupted 

[~mmalina] feels all newly detected runtimes should use the minishift_home set on the environment...   which will usually be ~/.minishift but could be something else this seems very bad to me, because 4 different cdks being detected will all be configured to use the same minishift_home 

[~jeffmaury] [~adietish]  What do you guys think here?  Should we use the default minishift_home passed in via the environment? Or should we create a new one for each detected runtime? 

> MINISHIFT_HOME is not propagated to new detected cdk binary properly
> --------------------------------------------------------------------
>
>                 Key: JBIDE-25901
>                 URL: https://issues.jboss.org/browse/JBIDE-25901
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, runtime-detection
>    Affects Versions: 4.5.3.Final
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>
> Following some of the changes to how cdk and runtime detection works (most notably that path to cdk binary can now be used for searching), I wanted to try and see if $MINISHIFT_HOME is still respected and works properly. And it seems to fail.
> I started devstudio with MINISHIFT_HOME=/Users/rasp/minishift_home, then ran runtime detection against /Users/rasp/tmp where a cdk binary was found. But the newly created adapter had this set up as minishift home: /Users/rasp/tmp/MINISHIFT_HOME
> That seems totally wrong.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)