[jbosstools-issues] [JBoss JIRA] (JBIDE-19181) correct naming of internal packages so that they're consistent across all openshift plugins

Jeff MAURY (JIRA) issues at jboss.org
Wed Apr 18 12:13:49 EDT 2018


     [ https://issues.jboss.org/browse/JBIDE-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff MAURY updated JBIDE-19181:
-------------------------------
    Fix Version/s: 4.6.x
                       (was: 4.5.x)


> correct naming of internal packages so that they're consistent across all openshift plugins
> -------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19181
>                 URL: https://issues.jboss.org/browse/JBIDE-19181
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: openshift
>    Affects Versions: 4.3.0.Alpha1
>            Reporter: Andre Dietisheim
>             Fix For: 4.6.x
>
>
> Internal packages across the openshift plugins are non-consistent:
> ex. 
> org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
> org.jboss.tools.openshift.express.client: org.jboss.tools.openshift.express.client.internal
> the base is imho org.jboss.tools.openshift and thus internal packages should always be at org.jboss.tools.openshift.internal across plugins.
> For reference, here's the official Eclipse documentation on the topic: http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages
> {quote}
>  org.eclipse.jdt.internal.core.compiler - Correct usage
>    org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow subproject name.
>    org.eclipse.core.internal.resources - Correct usage
>    org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
>    org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jbosstools-issues mailing list