[jbosstools-issues] [JBoss JIRA] (JBIDE-26098) Update dependencies in org.jboss.tools.stacks and repair test failures in jbosstools_base-master job

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-26098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613207#comment-13613207 ] 

Nick Boldt commented on JBIDE-26098:
------------------------------------

Latest build console log has this:

{code}
!MESSAGE Unable to create class 'org.eclipse.e4.ui.internal.workbench.addons.CommandProcessingAddon' from bundle '77'
!STACK 0
org.eclipse.e4.core.di.InjectionException: Unable to process "CommandProcessingAddon.broker": no actual value was found for the argument "IEventBroker".
	at org.eclipse.e4.core.internal.di.InjectorImpl.reportUnresolvedArgument(InjectorImpl.java:485)
	at org.eclipse.e4.core.internal.di.InjectorImpl.resolveRequestorArgs(InjectorImpl.java:476)
	at org.eclipse.e4.core.internal.di.InjectorImpl.internalInject(InjectorImpl.java:125)
	at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:408)
	at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:344)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:214)
	at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:108)
	at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:74)
	at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:51)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Application.createE4Workbench(E4Application.java:282)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:584)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:560)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148){code} -- https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-base_master/lastBuild/artifact/sources/stacks/tests/org.jboss.tools.stacks.core.test/target/work/data/.metadata/.log

[~akurtako] Does this look like something that changed in Eclipse 4.9?

[~odockal] If we look at the # of tests run since last year...

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-base_master/2415/testReport/
26 jul 2018: 374 passed, 1 skipped

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-base_master/1770/testReport/
22 mar 2018: 376 passed, 1 skipped

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-base_master/1228/testReport/
07 dec 2017: 376 passed, 1 skipped

https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/jbosstools-base_master/142/testReport/
29 may 2017: 372 passed, 1 skipped

So... it's only a couple tests that are no longer running. Is this really a show stopper?

> Update dependencies in org.jboss.tools.stacks and repair test failures in jbosstools_base-master job
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-26098
>                 URL: https://issues.jboss.org/browse/JBIDE-26098
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: qa
>    Affects Versions: 4.6.0.Final
>            Reporter: Ondrej Dockal
>            Assignee: Ondrej Dockal
>             Fix For: 4.9.0.AM1
>
>
> 1. Have stacks tests to be run on jenkins jbt-base master and pull request job and have them green (not just omitting stacks tests results). 
> 2. Update versions of maven plugins used as libraries in org.jboss.tools.stacks plugin: 
> * org.jboss.jdf.stacks-client; 1.0.3.Final -> no change
> * org.yaml.snakeyaml; 1.10 -> 1.18
> * org.apache.httpcomponents.httpclient; 4.0.1 -> 4.5.5
> * org.apache.httpcomponents.httpcore; 4.0.1 -> 4.4.9
> * org.jboss.logging.jboss-logging; 3.1.2.GA -> 3.3.2.Final
> 3. Run all stacks.tests available (only one test class was run)
> 4. Check on dependencies and usages in org.jboss.jdf.stacks-client and org.jboss.tools.stacks (what needs to be update, does it broke something, what else is using it)



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)