[jbosstools-issues] [JBoss JIRA] (JBIDE-26283) Baseline and reactor have same fully qualified version, but with different content in jbosstools-base plugins/features

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-26283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615097#comment-13615097 ] 

Andre Dietisheim edited comment on JBIDE-26283 at 8/6/18 7:52 AM:
------------------------------------------------------------------

[~nickboldt]: referring to your [findings|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=13614123&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13614123]:
* *Eclipse source references* are ignored and thus shouldn't trigger a baseline comparison failure (as found out by [~jeffmaury] in his [comment|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=13614264&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13614264]:
https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src/main/java/org/eclipse/tycho/zipcomparator/internal/ManifestComparator.java#L50
{code}
        // this is common attribute not supported by Tycho yet
        ignoredKeys.add(new Name("Eclipse-SourceReferences"));
{code}
* The other change in *properties* is in a comment abd shouldn't trigger a failure in baseline comparison. Comparison is done based on keys and values, where comments should be ignored: https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src/main/java/org/eclipse/tycho/zipcomparator/internal/PropertiesComparator.java#L42

So I still dont get why the baseline checks fails. Thoughts?


was (Author: adietish):
[~nickboldt]: referring to your [findings|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=13614123&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13614123] I ack that eclipse source references are ignored and thus shouldn't trigger a baseline comparison failure (as found out by [~jeffmaury] in his [comment|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=13614264&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13614264]:
https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src/main/java/org/eclipse/tycho/zipcomparator/internal/ManifestComparator.java#L50
{code}
        // this is common attribute not supported by Tycho yet
        ignoredKeys.add(new Name("Eclipse-SourceReferences"));
{code}
The other change in comments shouldn't trigger a failure in baseline comparison. Comparison is done based on keys and values, where comments should be ignored: https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src/main/java/org/eclipse/tycho/zipcomparator/internal/PropertiesComparator.java#L42

So I still dont get why the baseline checks fails. Thoughts?

> Baseline and reactor have same fully qualified version, but with different content in jbosstools-base plugins/features
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-26283
>                 URL: https://issues.jboss.org/browse/JBIDE-26283
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.9.0.AM1
>            Reporter: Josef Kopriva
>            Assignee: Nick Boldt
>            Priority: Blocker
>             Fix For: 4.9.0.AM2
>
>         Attachments: diff-baseline-with-local-build-commented-timestamps.png, diff-baseline-with-local-build-sourcereferences-cause-problem.png
>
>
> Job https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/devstudio_master/job/jbosstools-base_master/ is red for one week.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)