[jbosstools-issues] [JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626745#comment-13626745 ] 

Andre Dietisheim commented on JBIDE-22138:
------------------------------------------

The OpenShift server adapter now activates an "openshift" maven profile that it finds in the project that it publishes to OpenShift. Stopping the server adapter will deactivate the "openshift" maven profile. The implemtation was done in [PR #1785|https://github.com/jbosstools/jbosstools-openshift/pull/1785] and fixes this issue and JBIDE-26175.

The upstream bug in Eclipse WTP was file together with a suggested fix to [Eclipse bugzilla 538367|https://bugs.eclipse.org/bugs/show_bug.cgi?id=538367]. In the meantime We have a workaround in place in our OpenShift tooling.

Issues that remain were filed to the following JIRAs:
* Server adapter: shutting down Eclipse won't reset the maven profile that the adapter activated in the project (JBIDE-26330)
* Server adapter: switching maven profile (which determines the war name) won't undeploy the old war nor deploy the new one (JBIDE-26331)

> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
>                 Key: JBIDE-22138
>                 URL: https://issues.jboss.org/browse/JBIDE-22138
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>         Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
>            Reporter: Rafael Benevides
>            Assignee: Andre Dietisheim
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.9.0.AM3
>
>         Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello.adoc (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift" 
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)