[jbosstools-issues] [JBoss JIRA] (JBIDE-25551) Format Checker: dont enforce line feed

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512347#comment-13512347 ] 

Andre Dietisheim commented on JBIDE-25551:
------------------------------------------

[~dbocharov] I would have thought that telling the formatter *NOT* to join wrapped lines, which makes eclipse respect manual line wrapping, would help:
{code:title=eclipse-formatter.xml}
-<setting id="org.eclipse.jdt.core.formatter.join_wrapped_lines" value="true"/>
+<setting id="org.eclipse.jdt.core.formatter.join_wrapped_lines" value="false"/>
{code}
But it doesn't. Any idea?

> Format Checker: dont enforce line feed 
> ---------------------------------------
>
>                 Key: JBIDE-25551
>                 URL: https://issues.jboss.org/browse/JBIDE-25551
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.5.2.AM3
>            Reporter: Andre Dietisheim
>            Assignee: Dmitrii Bocharov
>
> Current format checks enforce line feeds which leads to badly readable code when you're using fluent builders like in the following case (see here: https://github.com/jbosstools/jbosstools-openshift/pull/1645/files?diff=unified#diff-16258aa0fb1a1d1ebc6bdc47a6604682R220):
> {code:title=enforced line feeds}
> TableViewer resourcesViewer = new TableViewerBuilder(table, tableContainer)
>  	.column(resource -> ((IResource) resource).getName()).name("Name").align(SWT.LEFT).weight(1)
> 	.minWidth(100).buildColumn().column(resource -> ((IResource) resource).getKind()).name("Type")
>  	.align(SWT.LEFT).weight(1).minWidth(100).buildColumn()
>  	.column(new LabelsCellLabelProvider(labelFilter)).name("Labels").align(SWT.LEFT).weight(2)
>  	.minWidth(200).buildColumn().buildViewer();
> {code}
> {code:title=manual line feeds with superior readability}
> TableViewer resourcesViewer = new TableViewerBuilder(table, tableContainer)
> 	.column(resource -> ((IResource) resource).getName())
>             .name("Name").align(SWT.LEFT).weight(1).minWidth(100).buildColumn()
>         .column(resource -> ((IResource) resource).getKind())
>             .name("Type").align(SWT.LEFT).weight(1).minWidth(100).buildColumn()
> 	.column(new LabelsCellLabelProvider(labelFilter))
>             .name("Labels").align(SWT.LEFT).weight(2).minWidth(200).buildColumn()
>        .buildViewer();
> {code}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)