[jbosstools-issues] [JBoss JIRA] (JBIDE-25551) Format Checker: dont enforce line feed

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13512650#comment-13512650 ] 

Andre Dietisheim commented on JBIDE-25551:
------------------------------------------

We currently use formatter plugin version 2.0.1 which doesnt seem to honour the above flag. When using the latest 2.7.1 though the flag seems getting honoured but the maven build fails stating 2.7.1 "Workspace closed". This is known to happen with Eclipse Oxygen 1a: https://github.com/revelc/formatter-maven-plugin/issues/260
Version 2.7.0 doesnt have the issue. But then, plenty of new complaints show up.
I'm postponing this to after 4.5.3.Final since there's no urgency for this. 

> Format Checker: dont enforce line feed 
> ---------------------------------------
>
>                 Key: JBIDE-25551
>                 URL: https://issues.jboss.org/browse/JBIDE-25551
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.5.2.AM3
>            Reporter: Andre Dietisheim
>            Assignee: Dmitrii Bocharov
>             Fix For: 4.5.x
>
>
> Current format checks enforce line feeds which leads to badly readable code when you're using fluent builders like in the following case (see here: https://github.com/jbosstools/jbosstools-openshift/pull/1645/files?diff=unified#diff-16258aa0fb1a1d1ebc6bdc47a6604682R220):
> {code:title=enforced line feeds}
> TableViewer resourcesViewer = new TableViewerBuilder(table, tableContainer)
>  	.column(resource -> ((IResource) resource).getName()).name("Name").align(SWT.LEFT).weight(1)
> 	.minWidth(100).buildColumn().column(resource -> ((IResource) resource).getKind()).name("Type")
>  	.align(SWT.LEFT).weight(1).minWidth(100).buildColumn()
>  	.column(new LabelsCellLabelProvider(labelFilter)).name("Labels").align(SWT.LEFT).weight(2)
>  	.minWidth(200).buildColumn().buildViewer();
> {code}
> {code:title=manual line feeds with superior readability}
> TableViewer resourcesViewer = new TableViewerBuilder(table, tableContainer)
> 	.column(resource -> ((IResource) resource).getName())
>             .name("Name").align(SWT.LEFT).weight(1).minWidth(100).buildColumn()
>         .column(resource -> ((IResource) resource).getKind())
>             .name("Type").align(SWT.LEFT).weight(1).minWidth(100).buildColumn()
> 	.column(new LabelsCellLabelProvider(labelFilter))
>             .name("Labels").align(SWT.LEFT).weight(2).minWidth(200).buildColumn()
>        .buildViewer();
> {code}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)