[jbosstools-issues] [JBoss JIRA] (JBIDE-25674) NPE in JolokiaConnectionWrapper.extractStatus

[Aurélien Pupier (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-25674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13525688#comment-13525688 ] 

Aurélien Pupier commented on JBIDE-25674:
-----------------------------------------

here is the calling stack:
{noformat}
Thread [Worker-36] (Suspended (entry into method <init> in J4pRemoteException))	
	owns: OpenshiftJMXConnectionProvider$1  (id=402)	
	J4pRemoteException.<init>(J4pRequest, String, String, int, String, JSONObject) line: 57	
	J4pClient.extractJsonResponse(REQ, HttpResponse) line: 278	
	J4pClient.execute(REQ, String, Map<J4pQueryParameter,String>, J4pResponseExtractor) line: 191	
	J4pClient.execute(REQ, String, Map<J4pQueryParameter,String>) line: 168	
	J4pClient.execute(REQ, String) line: 150	
	OpenshiftJMXConnectionProvider$1(JolokiaConnectionWrapper).verifyServerReachable() line: 311	
	OpenshiftJMXConnectionProvider$1(JolokiaConnectionWrapper).connect() line: 113	
	DoubleClickAction$1(ConnectJob).run(IProgressMonitor) line: 29	
	DoubleClickAction$1.run(IProgressMonitor) line: 71	
	Worker.run() line: 56	
{noformat}

it shows that the first constructor is used and in this case there is no initialization of the "response" attribute
https://github.com/rhuss/jolokia/blob/73a854b10c2d3679b6b3b3e79f1b875a98baa979/client/java/src/main/java/org/jolokia/client/exception/J4pRemoteException.java#L56

> NPE in JolokiaConnectionWrapper.extractStatus
> ---------------------------------------------
>
>                 Key: JBIDE-25674
>                 URL: https://issues.jboss.org/browse/JBIDE-25674
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jmx
>            Reporter: Aurélien Pupier
>
> {noformat}
> !ENTRY org.eclipse.core.jobs 4 2 2018-01-29 15:56:34.020
> !MESSAGE An internal error occurred during: "Connect Job".
> !STACK 0
> java.lang.NullPointerException
> 	at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.extractStatus(JolokiaConnectionWrapper.java:340)
> 	at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable(JolokiaConnectionWrapper.java:324)
> 	at org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.connect(JolokiaConnectionWrapper.java:113)
> 	at org.jboss.tools.jmx.core.ConnectJob.run(ConnectJob.java:29)
> 	at org.jboss.tools.jmx.ui.internal.actions.DoubleClickAction$1.run(DoubleClickAction.java:71)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56)
> {noformat}
> I put a breakpoint in org.jboss.tools.jmx.jolokia.JolokiaConnectionWrapper.verifyServerReachable() to see which exception it was and it is a "503 Service Unavailable"
> in this case the "response" is null
> 2 possibilities:
> - it is normal that it is null in this case Jboss Tools need to handle this case
> - it is not normal that it is null and in this case, it needs to be reported upstream (even if a null check might nice as a workaround for now)



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)