[jbosstools-issues] [JBoss JIRA] (JBIDE-26173) Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty

[Ondrej Dockal (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-26173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602268#comment-13602268 ] 

Ondrej Dockal commented on JBIDE-26173:
---------------------------------------

Also, error appears in Error log:
java.io.IOException: Cannot run program "": error=2, No such file or directory
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
	at org.jboss.tools.openshift.internal.core.preferences.OCBinaryValidator.getVersion(OCBinaryValidator.java:127)
	at org.jboss.tools.openshift.internal.ui.preferences.OpenShiftPreferencePage$2.run(OpenShiftPreferencePage.java:178)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:60)
Caused by: java.io.IOException: error=2, No such file or directory
	at java.lang.UNIXProcess.forkAndExec(Native Method)
	at java.lang.UNIXProcess.<init>(UNIXProcess.java:247)
	at java.lang.ProcessImpl.start(ProcessImpl.java:134)
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
	... 3 more

I think that switching of validation for empty oc location could be better. What if user do not want to set oc in preferences but only in openshift connection (aka override oc location)? 

> Validation for 'oc executable location' in Preferences OpenShift 3 page does not allow to keep value empty
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-26173
>                 URL: https://issues.jboss.org/browse/JBIDE-26173
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.6.0.Final
>            Reporter: Ondrej Dockal
>            Assignee: Andre Dietisheim
>            Priority: Critical
>
> When user chooses Preferences -> Jboss Tools -> OpenShift 3 and does nothing (ie. when one just clicked to wrong page), the page cannot be changed, 'Could not accept changes' dialog pops up and user must cancel Preferences dialog. 
> I suggest to not validate empty oc location.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)