[jbosstools-issues] [JBoss JIRA] (JBIDE-26178) Stacks errors when creating new server

[Ondrej Dockal (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-26178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603507#comment-13603507 ] 

Ondrej Dockal edited comment on JBIDE-26178 at 7/11/18 6:13 AM:
----------------------------------------------------------------

I have set up jboss-stacks jenkins verification job: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/JBoss%20Stacks/job/jboss-stacks/2/. It really show errors in yaml validation of changed files. 

Imho, it would be enough to run some unit tests when changing stacks and other yaml files in order to avoid this kind of bugs. 

Anyway, I will try to set up a PR check job and link it with github repo but it might require someone with proper rights.


was (Author: odockal):
I have set up jboss-stacks jenkins verification job: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/JBoss%20Stacks/job/jboss-stacks/2/. It really show errors in yaml validation of changed files. 

Imho, it would be enough to run some unit tests when changing stacks and other yaml files... 

> Stacks errors when creating new server
> --------------------------------------
>
>                 Key: JBIDE-26178
>                 URL: https://issues.jboss.org/browse/JBIDE-26178
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 4.6.0.Final
>            Reporter: Martin Malina
>            Assignee: Rob Stryker
>            Priority: Blocker
>             Fix For: 4.6.0.Final
>
>         Attachments: missing-commas.png, parse-errors.png
>
>
> When you try to create a server for the first time, stacks.yaml (and pre-stacks.yaml) is downloaded and currently it's invalid yaml, so there are errors thrown in the Error Log view.
> !parse-errors.png!
> One example:
> {code}
> Can't access or parse  https://raw.githubusercontent.com/jboss-developer/jboss-stacks/1.0.0.Final/pre-stacks.yaml
> {code}
> {code}
> while parsing a flow mapping
>  in "<reader>", line 201, column 12:
>        labels: {
>                ^
> expected ',' or '}', but got Value
>  in "<reader>", line 206, column 25:
>             wtp-runtime-type: org.jboss.ide.eclipse.as.runti ... 
>                             ^
> 	at org.yaml.snakeyaml.parser.ParserImpl$ParseFlowMappingKey.produce(ParserImpl.java:734)
> 	at org.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:160)
> 	at org.yaml.snakeyaml.parser.ParserImpl.checkEvent(ParserImpl.java:145)
> 	at org.yaml.snakeyaml.composer.Composer.composeMappingNode(Composer.java:230)
> 	at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:159)
> 	at org.yaml.snakeyaml.composer.Composer.composeMappingNode(Composer.java:237)
> 	at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:159)
> 	at org.yaml.snakeyaml.composer.Composer.composeSequenceNode(Composer.java:204)
> 	at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:157)
> 	at org.yaml.snakeyaml.composer.Composer.composeMappingNode(Composer.java:237)
> 	at org.yaml.snakeyaml.composer.Composer.composeNode(Composer.java:159)
> 	at org.yaml.snakeyaml.composer.Composer.composeDocument(Composer.java:122)
> 	at org.yaml.snakeyaml.composer.Composer.getSingleNode(Composer.java:105)
> 	at org.yaml.snakeyaml.constructor.BaseConstructor.getSingleData(BaseConstructor.java:120)
> 	at org.yaml.snakeyaml.Yaml.loadFromReader(Yaml.java:480)
> 	at org.yaml.snakeyaml.Yaml.load(Yaml.java:411)
> 	at org.jboss.jdf.stacks.parser.Parser.parse(Parser.java:55)
> 	at org.jboss.tools.stacks.core.model.StacksManager.getStacksFromFile(StacksManager.java:177)
> 	at org.jboss.tools.stacks.core.model.StacksManager.getStacksFromURL(StacksManager.java:163)
> 	at org.jboss.tools.stacks.core.model.StacksManager.getStacks(StacksManager.java:154)
> 	at org.jboss.tools.stacks.core.model.StacksManager.getStacks(StacksManager.java:141)
> 	at org.jboss.tools.stacks.core.model.StacksManager.getStacks(StacksManager.java:106)
> 	at org.fusesource.ide.server.fuse.core.runtime.integration.FuseDownloadRuntimesProvider.getStacks(FuseDownloadRuntimesProvider.java:29)
> 	at org.fusesource.ide.server.karaf.core.runtime.integration.AbstractStacksDownloadRuntimesProvider.loadDownloadableRuntimes(AbstractStacksDownloadRuntimesProvider.java:66)
> 	at org.fusesource.ide.server.karaf.core.runtime.integration.AbstractStacksDownloadRuntimesProvider.getDownloadableRuntimes(AbstractStacksDownloadRuntimesProvider.java:50)
> 	at org.jboss.tools.runtime.core.internal.RuntimeExtensionManager.loadDownloadableRuntimesFromProviders(RuntimeExtensionManager.java:273)
> 	at org.jboss.tools.runtime.core.internal.RuntimeExtensionManager.loadDownloadRuntimes(RuntimeExtensionManager.java:257)
> 	at org.jboss.tools.runtime.core.internal.RuntimeExtensionManager.getDownloadRuntimes(RuntimeExtensionManager.java:199)
> 	at org.jboss.tools.runtime.core.internal.RuntimeExtensionManager.getDownloadRuntimes(RuntimeExtensionManager.java:187)
> 	at org.jboss.tools.runtime.core.RuntimeCoreActivator.getDownloadRuntimes(RuntimeCoreActivator.java:136)
> 	at org.jboss.tools.as.runtimes.integration.util.DownloadRuntimeServerUtil.getDownloadRuntimes(DownloadRuntimeServerUtil.java:41)
> 	at org.jboss.tools.as.runtimes.integration.ui.composites.DownloadRuntimeHyperlinkComposite$1.run(DownloadRuntimeHyperlinkComposite.java:169)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:60)
> {code}
> Apparently [~rob.stryker] broke the file 14 hours ago with this commit:
> https://github.com/jboss-developer/jboss-stacks/commit/48ff290ca4c3f8e901fc1c3c3b29a0446ccf70a7
> See the missing commas here:
> !missing-commas.png!



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)