[jbosstools-issues] [JBoss JIRA] (JBIDE-26221) Server adapter wizard: reconfiguring oc will cause warning, where it should error

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-26221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607694#comment-13607694 ] 

Andre Dietisheim commented on JBIDE-26221:
------------------------------------------

In JBIDE-26173 we decided to have all problems in oc warnings only. In the server adapter wizard, problems with the oc binary on the other hand need to be errors. 
This issue is a usecase where turning warnings into errors for the server adapter wizard was missed.

> Server adapter wizard: reconfiguring oc will cause warning, where it should error
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-26221
>                 URL: https://issues.jboss.org/browse/JBIDE-26221
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.9.0.AM1
>            Reporter: Andre Dietisheim
>             Fix For: 4.9.0.AM1
>
>         Attachments: image-2018-07-18-17-15-31-065.png, image-2018-07-18-17-21-42-843.png
>
>
> # ASSERT: have a project with a service running on OpenShift
> # ASSERT: have the [PR|https://github.com/jbosstools/jbosstools-openshift/pull/1772] applied to your code
> # ASSERT: in OpenShift Preferences: have oc not configured (or alternatively have it pointed to a location with a " " - ex. ~/oc binaries/oc) -> in both cases preferences will display a warning
> # EXEC: launch server adapter wizard for your service
> # ASSERT: server adapter wizard shows an error with a link to "configure" the oc binary
>  !image-2018-07-18-17-15-31-065.png! 
> # EXEC: hit "configure" and then in preferences configure a fake oc file (ex. a dummy file that you created with "touch ~/oc && chmod +x oc"). 
> # ASSERT: after closing preferences you're back in the server adapter wizard
> Result:
> Server adapter wizard now shows a warning, while it should show an error
>  !image-2018-07-18-17-21-42-843.png! 



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)