[jbosstools-issues] [JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608752#comment-13608752 ] 

Andre Dietisheim edited comment on JBIDE-22138 at 7/20/18 2:57 PM:
-------------------------------------------------------------------

[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it always returns *false*.
Looking into delta(s) that are being analyzed I dont ever see *.settings/org.eclipse.wst.common.component* being passed in even though I clearly see the file being modified on disk.
I see the following paths being looked at:
{code}
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
{code}

A listener for *.settings/org.eclipse.wst.common.component* is registered, so if this path would be passed in, #deltaAffectsModules would return *true*. 

Listeners that are registered are the following:
{code}
.project 
.settings/org.eclipse.wst.common.component
.settings/org.eclipse.wst.common.project.facet.core.xml
.settings/org.eclipse.pde.core.prefs
META-INF/MANIFEST.MF
{code}



was (Author: adietish):
[~rob.stryker] When chaning the maven profile for a project (in this particular case, the profile overrides the warName) ProjectModuleFactoryDelegate#deltaAffectsModules is called several times (for each module factory) but it always returns *false*.
Looking into delta(s) that are being analyzed I dont ever see *.settings/org.eclipse.wst.common.component* being passed in even though I clearly see the file being modified on disk.
I see the following paths being looked at:
{code}
delta2 = ResourceDelta(/hello)
delta2 = ResourceDelta(/hello/target)
delta2 = ResourceDelta(/hello/.settings)
delta2 = ResourceDelta(/hello/.settings/org.eclipse.m2e.core.prefs)
{code}

A listener for *.settings/org.eclipse.wst.common.component* is registered, so if this path would be passed in, #deltaAffectsModules would return *true*. 


> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
>                 Key: JBIDE-22138
>                 URL: https://issues.jboss.org/browse/JBIDE-22138
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>         Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
>            Reporter: Rafael Benevides
>            Assignee: Andre Dietisheim
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.9.0.AM1
>
>         Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello.adoc (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift" 
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)