[jbosstools-issues] [JBoss JIRA] (JBIDE-22138) Server adapter: doesn't respect openshift maven profile

Rob Stryker (JIRA) issues at jboss.org
Fri Jul 20 19:34:00 EDT 2018


    [ https://issues.jboss.org/browse/JBIDE-22138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608839#comment-13608839 ] 

Rob Stryker commented on JBIDE-22138:
-------------------------------------

The only thing I can imagine is happening here is that the model is being updated, and not the file, and that somehow, wtp is suppressing firing a resource change event since the file is being updated via the model and not via the user. But I can't seem to find out how or why that'd be happening. I am actually shocked that that's even possible as I assumed a resource-change-event would be fired in all cases. 

So this is all very shocking to me. 

It does look like m2e is doing its part to update the model, but the wst.component thing is suppressing the resource change event, perhaps somewhere deep in EMF?  If that's the case, I'm not at all sure how we could override that behavior. So the 'fix' might have to be done in m2e. I'm assuming m2e is the one initiating the update to the wst.component via the model. m2e might need to be informed that that change is not sufficient to update the model in full. 

I would first look to see when / how that file is being changed, and then trace back to see who's doing it. A stacktrace of that event would be very insightful. 

> Server adapter: doesn't respect openshift maven profile
> -------------------------------------------------------
>
>                 Key: JBIDE-22138
>                 URL: https://issues.jboss.org/browse/JBIDE-22138
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>         Environment: JBoss Developer Studio (Core Features) 9.1.0.GA-v20160403-1700-B477
> Openshift plugin 3.1.0.Final-v20160401-2357-B263
>            Reporter: Rafael Benevides
>            Assignee: Andre Dietisheim
>              Labels: openshift_v3, server_adapter
>             Fix For: 4.9.0.AM1
>
>         Attachments: image-2018-06-22-19-02-57-247.png
>
>
> This is a follow up on JBIDE-22128.
> The maven profile is never read to determine the actual archive name. That will require more coupling to m2e, in order to load the pom.xml model using the openshift profile, if it exists, in order to determine the archive name. This will be a long running operation and will require more significant changes
> steps:
> # EXEC: follow steps outlined in https://github.com/redhat-helloworld-msa/helloworld-msa/blob/master/hello.adoc (deploying with fabric8 maven plugin doesn't work, you end up having the pod failing with ImagePullBack error. You need to take the alternative road where you deploy via "oc new-build", "oc new-app", "oc expose" etc.)
> # EXEC: import the app into your Eclipse workspace
> # EXEC: "hello" (workspace) project: Properties > Maven > Active Maven Profile: set "openshift" 
> # EXEC: create a server adapter and start it
> # ASSERT: adapter starts syncing, verify what war is used
> Result:
> The war that's created locally and then synced to the pod is "hello.war" even though the profile specifies "ROOT.war"



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jbosstools-issues mailing list