[jbosstools-issues] [JBoss JIRA] (JBIDE-21331) Connection wizard: it looks as if the wizard is creating new connection instances several times

[Andre Dietisheim (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-21331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim resolved JBIDE-21331.
--------------------------------------
    Fix Version/s: 4.5.3.Final
                       (was: 4.5.x)
         Assignee: Andre Dietisheim
       Resolution: Out of Date


The current code in the connection wizard doesn't have this issue any more. Resolving as OUT_OF_DATE

> Connection wizard: it looks as if the wizard is creating new connection instances several times
> -----------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21331
>                 URL: https://issues.jboss.org/browse/JBIDE-21331
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.3.0.Beta1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>            Priority: Minor
>              Labels: connection_wizard, openshift_v3
>             Fix For: 4.5.3.Final
>
>
> The connection wizard creates new connection instances in several places which seems unnecessary (we need it at least once where we dont want to modify an existing connection and operate on a copy before merging the changes back upon successfull verification)
> {code:title=ConnctionWizardPageModel} 
> 	private void initEditConnection(IConnection connection) {
> 		this.selectedConnection = connection;
> 		this.connection = connection.clone();
> 		...
> {code}
> {code:title=ConnctionWizardPageModel} 
> 	public IStatus connect() {
> 		...
> 		try {
> 			this.connection = createConnection();
> 		...
> {code}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)