[jbosstools-issues] [JBoss JIRA] (JBIDE-24492) Details for custom template are not shown until "Next" is pressed.

[Andre Dietisheim (Jira)]

    [ https://issues.jboss.org/browse/JBIDE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649087#comment-13649087 ] 

Andre Dietisheim commented on JBIDE-24492:
------------------------------------------

[~jkopriva] Indeed, this is a regression of JBIDE-23473. JBIDE-23473 changed the code so that the template is only loaded when the page is up to get flipped over:
{code:title=https://github.com/jbosstools/jbosstools-openshift/pull/1502/files#diff-518c8f0f0d3d47e02da65022370e7e9dR805}
	@Override
	protected void onPageWillGetDeactivated(Direction progress, PageChangingEvent event, DataBindingContext dbc) {
		if (model.isUseLocalAppSource()) {
			String filename = model.getLocalAppSourceFileName();
			if (StringUtils.isNotBlank(filename)) {
				Job job = new Job(NLS.bind("Loading application source", filename)) {
					@Override
					protected IStatus run(IProgressMonitor monitor) {
						model.loadAppSource(monitor);
						return Status.OK_STATUS;
					}
				};
{code}

 Before JBIDE-23473 the template was being loaded upon keystroke: 
{code:title=https://github.com/jbosstools/jbosstools-openshift/pull/1502/files#diff-518c8f0f0d3d47e02da65022370e7e9dL825}
    @Override
    public void handleValueChange(ValueChangeEvent<? extends Object> event) {
        if (model.isUseLocalAppSource()) {
            if (StringUtils.isNotBlank(model.getLocalAppSourceFileName())) {
                Job job = new Job("Loading application source") {
                    @Override
                    protected IStatus run(IProgressMonitor monitor) {
                        model.loadAppSource(monitor);
                        return Status.OK_STATUS;
                    }
                };
{code}

> Details for custom template are not shown until "Next" is pressed.
> ------------------------------------------------------------------
>
>                 Key: JBIDE-24492
>                 URL: https://issues.jboss.org/browse/JBIDE-24492
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.4.4.Final
>            Reporter: Radim Hopp
>            Assignee: Josef Kopriva
>            Priority: Major
>              Labels: application_wizard
>             Fix For: 4.10.0.AM1
>
>
> Almost certainly a regression caused by JBIDE-23473.
> I know that validation is now bound to pressing "Next" button, but this prevents from showing user the defined resources on first page of wizard in "Details" section. Maybe showing them on second page would solve the problem?
> Screencast: https://youtu.be/uGAmL_sMIXc



--
This message was sent by Atlassian Jira
(v7.12.1#712002)