[jbosstools-issues] [JBoss JIRA] (JBIDE-26148) CommandLocationBinary: only searches once (wont retry if it fails, forcing me to restart Eclipse once I corrected a broken link)

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-26148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629674#comment-13629674 ] 

Andre Dietisheim edited comment on JBIDE-26148 at 9/6/18 4:56 AM:
------------------------------------------------------------------

[~rob.stryker] If some kind of a trigger in preferences (like a button, a link, etc.) where the user can force a renewed search is what you're suggesting, then I'm all +1.
Thinking this issue through again made me believe that the edge case that we can fix here makes this a non-critical, non-urgent issue.


was (Author: adietish):
[~rob.stryker] If some kind of a trigger in preferences (like a button, a link, etc.) where the user can force a renewed search is what you're suggesting, then I'm all +1.
Thinking this issue through again made me think that the edge case that we can fix makes this a non-critical, non-urgent issue.

> CommandLocationBinary: only searches once (wont retry if it fails, forcing me to restart Eclipse once I corrected a broken link)
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-26148
>                 URL: https://issues.jboss.org/browse/JBIDE-26148
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.6.0.AM3
>            Reporter: Andre Dietisheim
>            Assignee: Rob Stryker
>             Fix For: 4.9.x
>
>
> [CommandLocationBinary|https://github.com/adietish/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.common.core/src/org/jboss/tools/openshift/internal/common/core/util/CommandLocationBinary.java#L70] allows to lookup a command (on the $PATH, etc.). But it'll only do so once:
> {code:title=CommandLocationBinary}
> 	public String findLocation(int timeout) {
> 		if (foundLoc != null || searchFailed)
> 			return foundLoc;
> 		String searched = CommandLocationLookupStrategy.get().search(this, timeout);
> 		if (searched == null) {
> 			searchFailed = true;
> 		}
> 		foundLoc = searched;
> 		return searched;
> 	}
> {code}
> Once the lookup failed, it'll store this in the var *searchFailed* and wont do it a 2nd time. 
> What if I update my ex. correct a broken link to oc while I keep Eclipse running? 
> I'd think that one should be able to repeat the lookup if it fails since the user could modify it's system while he keeps Eclipse running. Afaics the current impl forces me to restart Eclipse.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)