[jbosstools-issues] [JBoss JIRA] (JBIDE-26696) configuration file wizard: without settings, hitting "Finish" is possible and throws Exception in log
André Dietisheim (Jira)
issues at jboss.org
Fri Aug 9 07:04:00 EDT 2019
[ https://issues.jboss.org/browse/JBIDE-26696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769014#comment-13769014 ]
André Dietisheim commented on JBIDE-26696:
------------------------------------------
[~koen.aers] I can ok that an empty file is legal. But then the wizard is kept opened and an exception is thrown. I'd argue that if creating an empty file is ok, then the wizard should close and no exception should be thrown. Currently the wizard stays open and an exception is thrown. I didn't check if a config file was created but I'd think that it's not.
> configuration file wizard: without settings, hitting "Finish" is possible and throws Exception in log
> -----------------------------------------------------------------------------------------------------
>
> Key: JBIDE-26696
> URL: https://issues.jboss.org/browse/JBIDE-26696
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: hibernate
> Affects Versions: 4.12.0.AM1
> Reporter: André Dietisheim
> Assignee: Koen Aers
> Priority: Major
> Fix For: 4.13.0.AM1
>
> Attachments: image-2019-06-26-14-19-10-265.png
>
>
> steps:
> # ASSERT: have a project in workspace
> # EXEC: launch configuration file wizard File > New > Other > Hibernate > Hibernate Configuration File (cfg.xml)
> # EXEC: when asked, chose a location in your project > Next
> # ASSERT: Form for the connection settings is presented
> !image-2019-06-26-14-19-10-265.png!
> # ASSERT: "Finish" button is enabled, even though the form is invalid
> # EXEC: hit "Finish"
> Result:
> Wizard is kept open and in the Eclipse logs I can see the following exception:
> {code}
> org.hibernate.service.spi.ServiceException: Unable to create requested service [org.hibernate.engine.jdbc.env.spi.JdbcEnvironment]
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.createService(AbstractServiceRegistryImpl.java:275)
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.initializeService(AbstractServiceRegistryImpl.java:237)
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.getService(AbstractServiceRegistryImpl.java:214)
> at org.hibernate.id.factory.internal.DefaultIdentifierGeneratorFactory.injectServices(DefaultIdentifierGeneratorFactory.java:152)
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.injectDependencies(AbstractServiceRegistryImpl.java:286)
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.initializeService(AbstractServiceRegistryImpl.java:243)
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.getService(AbstractServiceRegistryImpl.java:214)
> at org.hibernate.boot.internal.InFlightMetadataCollectorImpl.<init>(InFlightMetadataCollectorImpl.java:175)
> at org.hibernate.boot.model.process.spi.MetadataBuildingProcess.complete(MetadataBuildingProcess.java:118)
> at org.hibernate.boot.model.process.spi.MetadataBuildingProcess.build(MetadataBuildingProcess.java:83)
> at org.hibernate.boot.internal.MetadataBuilderImpl.build(MetadataBuilderImpl.java:473)
> at org.hibernate.boot.internal.MetadataBuilderImpl.build(MetadataBuilderImpl.java:84)
> at org.hibernate.boot.MetadataSources.buildMetadata(MetadataSources.java:184)
> at org.jboss.tools.hibernate.runtime.v_5_4.internal.util.MetadataHelper.buildFromMetadataSources(MetadataHelper.java:49)
> at org.jboss.tools.hibernate.runtime.v_5_4.internal.util.MetadataHelper.getMetadata(MetadataHelper.java:21)
> at org.jboss.tools.hibernate.runtime.v_5_4.internal.ConfigurationFacadeImpl.getMetadata(ConfigurationFacadeImpl.java:174)
> at org.jboss.tools.hibernate.runtime.v_5_4.internal.util.ConfigurationMetadataDescriptor.createMetadata(ConfigurationMetadataDescriptor.java:20)
> at org.hibernate.tool.hbm2x.AbstractExporter.buildMetadata(AbstractExporter.java:206)
> at org.hibernate.tool.hbm2x.AbstractExporter.getMetadata(AbstractExporter.java:56)
> at org.hibernate.tool.hbm2x.AbstractExporter.setupContext(AbstractExporter.java:177)
> at org.hibernate.tool.hbm2x.AbstractExporter.start(AbstractExporter.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.jboss.tools.hibernate.runtime.common.Util.invokeMethod(Util.java:43)
> at org.jboss.tools.hibernate.runtime.common.AbstractExporterFacade.start(AbstractExporterFacade.java:72)
> at org.hibernate.eclipse.console.wizards.NewConfigurationWizard.openContentStream(NewConfigurationWizard.java:301)
> at org.hibernate.eclipse.console.wizards.NewConfigurationWizard.access$2(NewConfigurationWizard.java:295)
> at org.hibernate.eclipse.console.wizards.NewConfigurationWizard$1.getInitialContents(NewConfigurationWizard.java:163)
> at org.eclipse.ui.dialogs.WizardNewFileCreationPage.createNewFile(WizardNewFileCreationPage.java:360)
> at org.hibernate.eclipse.console.wizards.NewConfigurationWizard.performFinish(NewConfigurationWizard.java:198)
> at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:833)
> at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:472)
> at org.eclipse.jface.dialogs.Dialog.lambda$0(Dialog.java:622)
> at org.eclipse.swt.events.SelectionListener$1.widgetSelected(SelectionListener.java:84)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:252)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4364)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1512)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1535)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1520)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1324)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4151)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3768)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:823)
> at org.eclipse.jface.window.Window.open(Window.java:799)
> at org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:260)
> at org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:280)
> at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:283)
> at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:95)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:58)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:320)
> at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:254)
> at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:173)
> at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:156)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:498)
> at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
> at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
> at org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:392)
> at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:142)
> at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:580)
> at org.eclipse.jface.action.ActionContributionItem.lambda$4(ActionContributionItem.java:412)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4364)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1512)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1535)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1520)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1324)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4151)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3768)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1173)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
> at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1062)
> at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
> at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:635)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:559)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:155)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:660)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:597)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1468)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1441)
> Caused by: org.hibernate.HibernateException: Access to DialectResolutionInfo cannot be null when 'hibernate.dialect' not set
> at org.hibernate.engine.jdbc.dialect.internal.DialectFactoryImpl.determineDialect(DialectFactoryImpl.java:100)
> at org.hibernate.engine.jdbc.dialect.internal.DialectFactoryImpl.buildDialect(DialectFactoryImpl.java:54)
> at org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator.initiateService(JdbcEnvironmentInitiator.java:137)
> at org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator.initiateService(JdbcEnvironmentInitiator.java:35)
> at org.hibernate.boot.registry.internal.StandardServiceRegistryImpl.initiateService(StandardServiceRegistryImpl.java:101)
> at org.hibernate.service.internal.AbstractServiceRegistryImpl.createService(AbstractServiceRegistryImpl.java:263)
> ... 96 more
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
More information about the jbosstools-issues
mailing list