[jbosstools-issues] [JBoss JIRA] (JBDS-4777) Please document procedure (if possible) for defining Debug port, Deployment path

[André Dietisheim (Jira)]

    [ https://issues.jboss.org/browse/JBDS-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746919#comment-13746919 ] 

André Dietisheim edited comment on JBDS-4777 at 6/14/19 2:37 PM:
-----------------------------------------------------------------

Things fail in the Eclipse server adapter because the tooling is unable to determine the docker image that the labels should be extracted from:

Our current strategy is to get the docker image from a deployment config/ImageChange trigger. This worked fine in the s2i use case that was more common to us. 
In this particular case where a pre-built docker image is deployed *ImageChange* triggers are not present. The triggers that are present are *ConfigChange* triggers which lack the docker image uri.
{code:title=expected: DeploymentConfig with ImageChange trigger}
"triggers": [
  {
    "type": "ImageChange",
    "imageChangeParams": {
      "automatic": true, 
      "from": {
        "kind": "ImageStreamTag",
        "name": "origin-ruby-sample:latest"
      },
      "containerNames": [
        "helloworld"
      ]
    }
  }
]
{code}
{code:title=present: DeploymentConfig with ConfigChange trigger}
"triggers": [
     {
        "type": "ConfigChange"
     }
]
{code}

{code:title=our code that retrieves the docker image - https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/DockerImageLabels.java#L141}
IDeploymentImageChangeTrigger trigger = getImageChangeTrigger(dc.getTriggers());
if (trigger == null) {
	return null;
}
DockerImageURI uri = trigger.getFrom();
{code}

A temporary work around could be to use s2i instead of a pre-built docker image.


was (Author: adietish):
Things fail in the Eclipse server adapter because the tooling is unable to determine the docker image that the labels should be extracted from:

Our current strategy is to get the docker image from a deployment config/ImageChange trigger. This worked fine in the s2i use case that was more common to us. 
In this particular case where a pre-built docker image is deployed *ImageChange* triggers are not present. The triggers that are present are *ConfigChange* triggers which lack the docker image uri.
{code:title=expected: DeploymentConfig with ImageChange trigger}
"triggers": [
  {
    "type": "ImageChange",
    "imageChangeParams": {
      "automatic": true, 
      "from": {
        "kind": "ImageStreamTag",
        "name": "origin-ruby-sample:latest"
      },
      "containerNames": [
        "helloworld"
      ]
    }
  }
]
{code}
{code:title=present: DeploymentConfig with ConfigChange trigger}
        "triggers": [
            {
                "type": "ConfigChange"
            }
        ]
{code}

{code:title=our code that retrieves the docker image - https://github.com/jbosstools/jbosstools-openshift/blob/master/plugins/org.jboss.tools.openshift.core/src/org/jboss/tools/openshift/core/server/DockerImageLabels.java#L141}
		IDeploymentImageChangeTrigger trigger = getImageChangeTrigger(dc.getTriggers());
		if (trigger == null) {
			return null;
		}
		DockerImageURI uri = trigger.getFrom();
{code}

A temporary work around could be to use s2i instead of a pre-built docker image.

> Please document procedure (if possible) for defining Debug port, Deployment path
> --------------------------------------------------------------------------------
>
>                 Key: JBDS-4777
>                 URL: https://issues.jboss.org/browse/JBDS-4777
>             Project: Red Hat CodeReady Studio (devstudio)
>          Issue Type: Feature Request
>          Components: openshift
>    Affects Versions: 12.11.0.GA
>         Environment: CodeReady Studio 12.11
>            Reporter: Rick Wagner
>            Assignee: Jeff MAURY
>            Priority: Major
>              Labels: openshift
>             Fix For: 12.x
>
>         Attachments: Problem_Description.pdf
>
>
> Please document procedure for pre-filling the following in Adapter Server Settings:
> - Pod Deployment Path
> - Debugging Key
> - Debugging Port
> Can this be done via image Labels from an imported Docker image?



--
This message was sent by Atlassian Jira
(v7.12.1#712002)