[jbosstools-issues] [JBoss JIRA] (JBIDE-26854) Cannot create CDK Server adapter: "The selected folder does not have a Vagrantfile"

[Ondrej Dockal (Jira)]

    [ https://issues.jboss.org/browse/JBIDE-26854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788409#comment-13788409 ] 

Ondrej Dockal commented on JBIDE-26854:
---------------------------------------

[~adietish] [~rob.stryker] I probably found a buggy line.

When changing method prototype of validateHomeDirectory it got changed in parent ([CDKServerWizardFragment.validateHomeDirectory|https://github.com/jbosstools/jbosstools-openshift/pull/1869/files#diff-51c5677cb3642e444d3560391901af05R249]) and in all places where it is called, but the prototype did not change in child class [CDK3ServerWizardFragmet.validateHomeDirectory|https://github.com/jbosstools/jbosstools-openshift/pull/1869/files#diff-2bf75d263e1926e1938036bb25858e70R188] method was left without input parameters. So the parent's validation was called instead - So that's where vagrant validation came into game.

> Cannot create CDK Server adapter: "The selected folder does not have a Vagrantfile"
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-26854
>                 URL: https://issues.jboss.org/browse/JBIDE-26854
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, openshift
>    Affects Versions: 4.13.0.AM1
>            Reporter: Ondrej Dockal
>            Assignee: Rob Stryker
>            Priority: Blocker
>              Labels: regression
>             Fix For: 4.13.0.Final
>
>         Attachments: Screenshot_20190923_171358.png
>
>
> CDK Server wizard validation got broken after merging CRC support into Openshift Tooling. 
>  !Screenshot_20190923_171358.png|thumbnail! 



--
This message was sent by Atlassian Jira
(v7.13.8#713008)