[jbosstools-issues] [JBoss JIRA] (JBIDE-26878) Improve validation of CRC Binary and Pull Secret File in CRC Server Wizard and Editor

[Ondrej Dockal (Jira)]

     [ https://issues.jboss.org/browse/JBIDE-26878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ondrej Dockal updated JBIDE-26878:
----------------------------------
    Summary: Improve validation of CRC Binary and Pull Secret File in CRC Server Wizard and Editor  (was: Improve validation of Pull Secret File in CRC Server Wizard and Editor)


> Improve validation of CRC Binary and Pull Secret File in CRC Server Wizard and Editor
> -------------------------------------------------------------------------------------
>
>                 Key: JBIDE-26878
>                 URL: https://issues.jboss.org/browse/JBIDE-26878
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: cdk
>    Affects Versions: 4.13.0.Final
>            Reporter: Ondrej Dockal
>            Assignee: Rob Stryker
>            Priority: Major
>             Fix For: 4.13.0.Final
>
>
> I can image improved validation of Pull secret file that is available in CRC Server wizard and Server Editor. 
> I can imagine all of those validation in action for pull secret path input:
> * Path does not exist
> * Is not a file
> * Is not executable (user cannot read the file)
> * Is not a valid Pull secret file (probably check for if file's content is a valid json and/or we can probably validate if json's first object is "auths"? This would be nice, but simple json validation seems fine)
> I believe that last three points could be validated at once by reading the file's content and creating valid json object, or else showing the error that given path is no valid a secret file. It's up implementation, right?



--
This message was sent by Atlassian Jira
(v7.13.8#713008)