[jbosstools-issues] [JBoss JIRA] (JBIDE-26917) CDK runtime detection does not work for folder with minishift.exe on windows system

[André Dietisheim (Jira)]

    [ https://issues.redhat.com/browse/JBIDE-26917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968411#comment-13968411 ] 

André Dietisheim edited comment on JBIDE-26917 at 2/11/20 6:27 AM:
-------------------------------------------------------------------

[~jeffmaury] that's expected as in the above regex: it would match 
* crc(.exe)
* cdk-<num><anyalphanum><num>(<alphanum>*)\-minishift-<linux>/<darwin>/windows-amd64(<alphanum>exe)
Since minishift(.exe) is not it in this list, it wont match.

To me the regex looks broken. If that's the reason for this bug (I can't reproduce, dont have windows, should be broken for mac too though), then it should be easy fix it by correcting the regex. 
What makes me doubtful though is that this regex is expected to miss minishift(.exe) since 5Mt.
[~odockal], [~jeffmaury] is this runtime detection really broken for *minishift(.exe)* since 5Mt?


was (Author: adietish):
[~jeffmaury] that's expected as in the above regex: it would match 
* crc(.exe)
* cdk-<num><anyalphanum><num>(<alphanum>*)\-minishift-<linux>/<darwin>/windows-amd64(<alphanum>exe)
Since minishift(.exe) is not it in this list, it wont match.

To me the regex looks broken. If that's the reason for this bug (I can't reproduce, dont have windows, should be broken for mac too though), then it should be easy fix it by correcting the regex. 
What makes me doubtful though is that this regex is expected to miss minishift(.exe) since 5Mt. It is also missing my crc binaries which are as follows: crc-macos-1.0.0-amd64
[~odockal], [~jeffmaury] is this runtime detection really broken for *minishift(.exe)* since 5Mt? Is it really also broken for crc detection?


> CDK runtime detection does not work for folder with minishift.exe on windows system
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-26917
>                 URL: https://issues.redhat.com/browse/JBIDE-26917
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: cdk, openshift, runtime-detection
>    Affects Versions: 4.13.0.Final
>         Environment: Windows 10
>            Reporter: Ondrej Dockal
>            Assignee: André Dietisheim
>            Priority: Critical
>             Fix For: 4.14.0.Final
>
>
> Runtime detection does not find CDK server adapter when given folder with minishift.exe binary. It does not happen on linux systems.
> Steps:
> 1. Have studio opened and CDK binary downloaded
> 2. Preferences -> JBossTools -> Jboss Runtime Detection
> 3. Add 
> 4. Choose folder with cdk binary -> Open
> 5. ASSERT: Searching for runtimes dialog is shown with offered CDK 3.2+ server adapter
> Acutally: on windows it does not recognize adapter. On linux this works.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)