[jbossts-issues] [JBoss JIRA] Commented: (JBTM-535) make RecoveryManager restartable

[Mauro Molinari (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBTM-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12464799#action_12464799 ] 

Mauro Molinari commented on JBTM-535:
-------------------------------------

Another thought about the Listener.finalize() method: it is useless also because if the Listener is running, it can't be finalized, so finalize() will never be called. Viceversa, if finalize() is called it means that the listener has already been stopped, so its finalize() implementation is useless... am I wrong?

> make RecoveryManager restartable
> --------------------------------
>
>                 Key: JBTM-535
>                 URL: https://jira.jboss.org/jira/browse/JBTM-535
>             Project: JBoss Transaction Manager
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: Application Server Integration, Recovery
>    Affects Versions: 4.6.1
>            Reporter: Mauro Molinari
>            Assignee: Mark Little
>
> Issue JBTM-468 is not completely solved.
> com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery in its shutdown(boolean) method does not stop the _listener, so a call to _listener.stopListener() should be added to it. Otherwise the listener is never stopped and this can cause a leak if the JVM does not terminate between restarts.
> Moreover, as Listener threads are always started as daemon threads, I think com.arjuna.ats.internal.arjuna.recovery.Listener.finalize() is quite useless: if the JVM is terminating, the thread is stopped because it's a daemon thread, while in case of restart the Listener is certainly stopped by the restart process (bugs permitting). As it is right now, that finalize() method just causes useless GC overhead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira