[jbossts-issues] [JBoss JIRA] Commented: (JBTM-438) Consider flattening the property file (again)

Thu Jul 2 07:31:51 EDT 2009

    [ https://jira.jboss.org/jira/browse/JBTM-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12474585#action_12474585 ] 

Jonathan Halliday commented on JBTM-438:
----------------------------------------

Converted the properties file to use the java.util.Properties XML format, which has the advantage of being well documented and handled automatically by the std libs. Note that this has a knock on effect on the recovery modules which read xml, as they use the same parsing code. The new format is not compatible with the old one - uses with customized properties file will need to manually change over. Updated the user docs so that examples use the new format.

Changed the build system to have one default properties file per product (ArjunaCore, ArjunaJTA, ArjunaJTS) rather than find grained snippets per module. This makes for simpler and more obvious management of the defaults, as well as reducing our dependence on custom ant tasks, thus moving us further towards being able to build with other tools if desired

Also removed the public member variables in the per module property manager classes, leaving only the public getter methods. This forces lookup of the properties to pass back to the PropertyManagerFactory in all cases, allowing for a single point of instantiating and caching, thus facilitating future reloading of config if desired as part of the lifecycle support work.

Dusted off the old common module unit tests, converted them to junit4 and hooked them into the build. Test coverage for the properties management code is still insufficient but it's a start.

> Consider flattening the property file (again)
> ---------------------------------------------
>
>                 Key: JBTM-438
>                 URL: https://jira.jboss.org/jira/browse/JBTM-438
>             Project: JBoss Transaction Manager
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Configuration
>    Affects Versions: 4.4.0.GA
>            Reporter: Mark Little
>            Assignee: Jonathan Halliday
>             Fix For: 4.8.0
>
>
> At one time the configuration file was relatively straightforward. Then we added support for nested scopes and dependencies between scopes. This is overkill these days, so we should consider going back to a nice straightforward property file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira