[jbossts-issues] [JBoss JIRA] Commented: (JBTM-564) TransactionReaper code is not waking up threads correctly

[Andrew Dinn (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBTM-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12470766#action_12470766 ] 

Andrew Dinn commented on JBTM-564:
----------------------------------

Another problem is that the shutdown code is synchronizing on the reaper thread and reaper worker thread when it calls their respective shutdown methods but these threads synchronize on the transaction reaper object and the reaper work queue, respectively.


> TransactionReaper code is not waking up threads correctly
> ---------------------------------------------------------
>
>                 Key: JBTM-564
>                 URL: https://jira.jboss.org/jira/browse/JBTM-564
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 4.6.1
>            Reporter: Andrew Dinn
>            Assignee: Andrew Dinn
>
> The code in TransactionReaper is using wait and notify to suspend and wake up threads contending to add and remove transaction controls and to manage transfer of expired controls between the main queue and the reaper worker queue. It should actually be calling notifyAll() since notify() only wakes up one thread and multiple threads may be queued. All occurences of calls to notify() need to be transformed to notifyAll().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira