[jbossts-issues] [JBoss JIRA] Created: (JBTM-832) disable finalizer on BasicAction

Tue Mar 29 06:18:37 EDT 2011

disable finalizer on BasicAction
--------------------------------

                 Key: JBTM-832
                 URL: https://issues.jboss.org/browse/JBTM-832
             Project: JBoss Transaction Manager
          Issue Type: Task
      Security Level: Public (Everyone can see)
          Components: Configuration, Transaction Core
    Affects Versions: 4.14.0
            Reporter: Jonathan Halliday
            Assignee: Jonathan Halliday
             Fix For: 4.15.0

Finalizers are evil and must die. Most of them got killed off as part of JBTM-294. The remaining pain point was transactions themselves, hence JBTM-811.

Unfortunately the StateManager subclass BasicAction has has a finalizer, so removing the StateManager one does not entirely fix the issue for transactions types derived from BasicAction, which is pretty much all of them.

Nuking the BasicAction finalizer completely is probably overkill - in certain use cases it is handy to have the cleanup as a safetynet. In the majority of use cases however, cleanup is already provided by transaction timeouts via the reaper. Thus we benefit from the finalizer only in certain scenarios, whilst paying the price for every transaction.

Make the finalizer optional via a config flag.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira