[jbossts-issues] [JBoss JIRA] Commented: (JBTM-849) registerSynchronization fails with wrong status message

[Jonathan Halliday (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605439#comment-12605439 ] 

Jonathan Halliday commented on JBTM-849:
----------------------------------------

The JTA spec does not provide a distinct Status value for this phase and to use PREPARING would IMO be incorrect as previous described.  Nor does ArjunaCore regard termination phase0 (beforeCompletion) as a distinct internal state in the tx lifecycle. For ABORT_ONLY (aka ROLLBACK_ONLY) and ABORTED the internal status reported in the error msg does make more clear sense. For this Synchronization ordering issue the reported state, whilst accurate, is largely irrelevant. The text of the error message should make the actual likely cause clearer.

> registerSynchronization fails with wrong status message
> -------------------------------------------------------
>
>                 Key: JBTM-849
>                 URL: https://issues.jboss.org/browse/JBTM-849
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JTA
>    Affects Versions: 4.15.1
>         Environment: https://github.com/jbossejb3/jboss-as/tree/991e836c1bcb6b471010c5930fc3f58e72ed7972
>            Reporter: Carlo de Wolf
>         Attachments: JBTM-849-stracktrace.txt
>
>
> registerSynchronization is called from within a beforeCompletion of another Synchronization. I would expect the status to be PREPARING (or anything but RUNNING).
> {noformat}
> java.lang.IllegalStateException: Synchronizations are not allowed! Transaction status isActionStatus.RUNNING
> 	at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.registerSynchronizationImple(TransactionImple.java:367)
> 	at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.registerSynchronization(TransactionImple.java:344)
> 	at org.jboss.jca.core.connectionmanager.transaction.TransactionSynchronizer.getRegisteredSynchronizer(TransactionSynchronizer.java:198)
> 	at org.jboss.jca.core.connectionmanager.listener.TxConnectionListener.enlist(TxConnectionListener.java:210)
> 	at org.jboss.jca.core.connectionmanager.tx.TxConnectionManagerImpl.managedConnectionReconnected(TxConnectionManagerImpl.java:407)
> 	... 104 more
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira