[jbossts-issues] [JBoss JIRA] (JBTM-465) Consider allowing JDBCImple to manage connection lifecycles

Tom Jenkinson (JIRA) jira-events at lists.jboss.org
Thu Dec 6 05:22:21 EST 2012


    [ https://issues.jboss.org/browse/JBTM-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739877#comment-12739877 ] 

Tom Jenkinson commented on JBTM-465:
------------------------------------

Hi Mauro,

Thanks for the feedback, take a look at: https://github.com/jbosstm/narayana/blob/4.17/ArjunaCore/arjuna/tests/classes/com/hp/mwtests/ts/arjuna/objectstore/JDBCStoreTest.java and https://github.com/jbosstm/narayana/blob/4.17/ArjunaCore/arjuna/src/test/resources/jbossts-properties.xml in particular the reference to https://github.com/jbosstm/narayana/blob/4.17/ArjunaCore/arjuna/classes/com/arjuna/ats/internal/arjuna/objectstore/jdbc/accessors/DynamicDataSourceJDBCAccess.java and https://github.com/jbosstm/narayana/blob/4.17/ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/objectstore/jdbc/JDBCAccess.java.

I have tried to make JBTM-1230 as generic as possible and as you can see from the test I linked to, it does not require JNDI.

Also, I can't speak for the patches before too much as JDBC Object Store was somewhat off the "hot plate" and so by the time we had chance to review them, it is possible that they didn't overlay cleanly any more. That said, if you have any further patches against https://github.com/jbosstm/narayana/ they can be raised using our pull req mechanism, automatically CI'd and are so much easier to integrate so it should be much smoother these days. You will have to forgive me as I don't know how to retrieve the list of confirmed CLA signers, but I assume you have signed: https://cla.jboss.org/

Thanks again for contributing!
Tom
                
> Consider allowing JDBCImple to manage connection lifecycles
> -----------------------------------------------------------
>
>                 Key: JBTM-465
>                 URL: https://issues.jboss.org/browse/JBTM-465
>             Project: JBoss Transaction Manager
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Resource Manager
>    Affects Versions: 4.5.0
>            Reporter: Mark Little
>            Assignee: Tom Jenkinson
>             Fix For: 4.17.3, 5.0.0.M2
>
>
> JDBCImple assumes that the JDBCAccess class manages the lifecycle of connections it returns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbossts-issues mailing list