[jbossts-issues] [JBoss JIRA] (JBTM-527) Adding PMD to build system

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677780#comment-12677780 ] 

Tom Jenkinson commented on JBTM-527:
------------------------------------

Hi Romain,

If you still would like this fix, please can you consider raising a pull request on the Narayana project and we can take a look at it.

The new build system uses maven so you could add pmd into a profile and don't enable that profile by default?

Thanks,
Tom

PS If you no longer require this feature please consider closing this issue and marking as deferred
                
> Adding PMD to build system 
> ---------------------------
>
>                 Key: JBTM-527
>                 URL: https://issues.jboss.org/browse/JBTM-527
>             Project: JBoss Transaction Manager
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Build System
>            Reporter: Romain PELISSE
>            Assignee: Tom Jenkinson
>            Priority: Trivial
>              Labels: build, code, pmd, quality
>             Fix For: 5.0.1.Final
>
>         Attachments: adding-pmd-as-qa-tools.patch, jars.zip
>
>
> I have a small patch that offers an integration of PMD (http://pmd.sourceforge.net/) into the current build system of JBoss Transaction. Obviously, this is not an highly important feature request,  having PMD checking java code is just nice to have. Anyway, as your project is not likely to integrate this patch quickly, I also published the result of a PMD run on the current source code: 
> http://belaran.eu/jbosstm-pmd.html
> (this way you can already check what PMD find out without setting up the tool itself)
> I integrated PMD into the qa/ directory which seems the most appropriate directory at first glance... An other strategy would have been to define a "pmd" task inside some common build file ( maybe common/build.xml but it does not look like it), and then have each module call for this anttask with the appropriate java source folder... If you fell this approach is better, please let me know, i'll adapt my patch.
> All "violation" detected by PMD are not relevant, a pmd report is just a set of hints of something that may be a bad idea or could be improved. 
> PMD rulesets (what kind of violation is looking for) are defined in the qa/pmd.xml. In this file you can easily include/exclude rules, and you can use it to configure the PMD Eclipse Plugin. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira