[jbossts-issues] [JBoss JIRA] (JBTM-1481) Transaction::commit on an transaction that the reaper has tried to rollback but has a wedged resource will not raise an exception

Tom Jenkinson (JIRA) jira-events at lists.jboss.org
Thu Feb 21 06:02:57 EST 2013

     [ https://issues.jboss.org/browse/JBTM-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Jenkinson updated JBTM-1481:

    Attachment: WedgedResourceDemonstrator.java

The test case confirms this only affects JTS.

JTA is able to cope with this for two reasons: 
1. It is more eager to treat random exceptions from the XAResource as a failure
2. When commit is called on a rolled back transaction it locally checks if the transaction is in state rollback or rolling back and then performs a second attempted abort which the system detects and returns the correct error code

The attached patch fixes both of these (the stack trace is to be consistent with the JTA version to ensure the "logging api" remains consistent for detecting this case).
> Transaction::commit on an transaction that the reaper has tried to rollback but has a wedged resource will not raise an exception
> ---------------------------------------------------------------------------------------------------------------------------------
>                 Key: JBTM-1481
>                 URL: https://issues.jboss.org/browse/JBTM-1481
>             Project: JBoss Transaction Manager
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 4.6.1.CP13
>            Reporter: Tom Jenkinson
>            Assignee: Tom Jenkinson
>            Priority: Critical
>             Fix For: 4.6.1.CP14
>         Attachments: JBTM-1481.patch, WedgedResourceDemonstrator.java
> If you are getting a wedged resource. What then happens is that we interrupt the original reaper thread that is calling XAResource::rollback on the wedged resource which because you are using JacORB and have an in progress call will generate a null pointer exception when the thread is interrupted (you can see this in my attached log file, it prints a stack trace where the logging didn't do so before) which generates a org.omg.CORBA.TRANSACTION_ROLLEDBACK exception.
> The problem is that after the reaper tries to rollback the transaction but stalls on a wedged resource, it is then possible for the app thread to unwedged and to do a JTA::commit() and not get an exception. Debugging through the code, it doesn't pose data integrity issues on the transaction as what is happening is that internally we are checking the status of the transaction:
> ./ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/coordinator/ArjunaTransactionImple.java:340
> And because the transaction is not RUNNING or ABORT_ONLY, we are:
> ./ArjunaJTS/jts/classes/com/arjuna/ats/internal/jts/orbspecific/coordinator/ArjunaTransactionImple.java:398:
> throw new INVALID_TRANSACTION(0, CompletionStatus.COMPLETED_NO)
> Which is all good so far but then ends up in:
> ./ArjunaJTS/jtax/classes/com/arjuna/ats/internal/jta/transaction/jts/TransactionImple.java:1425
>             catch (INVALID_TRANSACTION e6)
>             {
>                 /*
>                  * In JTS/OTS we can indicate that something was terminated by another thread.
>                  * JTA doesn't really prevent this, but ...
>                  */
>                 //throw new IllegalStateException(
>                 //        jtaLogger.loggerI18N.getString("com.arjuna.ats.internal.jta.transaction.jts.invalidtx2"));
>             }
> Where it appears at some point we would have thrown an exception but decided to make the call that this was not valid anymore.
> As I say, it doesn't pose data integrity implications to the specific transaction, but if your app thread unwedges and you then make a decision on the outcome of the transaction (send email, acknowledge success) then it would break the business rules of that application.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

More information about the jbossts-issues mailing list