[jbossts-issues] [JBoss JIRA] (JBTM-1430) Restore commit method to AtomicAction

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746156#comment-12746156 ] 

Tom Jenkinson commented on JBTM-1430:
-------------------------------------

Sure, after committing https://github.com/jbosstm/narayana/commit/43e7bdd94cce6ec051587dcdc433139d79fb4646, I have repeated my search for @deprecated and can't find anything else problematic. 

FYI, this is the search I am using to find public deprecated methods, until you update you will also see the ones I have fixed:
[tom at localhost narayana](master) $ find . -name \*.java -exec grep -l  "@deprecated" {} \; | grep -v internal
./txbridge/src/main/java/org/jboss/jbossts/txbridge/inbound/InboundBridgeManager.java
./ArjunaJTS/jts/classes/com/arjuna/ats/jts/recovery/RecoveryEnvironment.java
./ArjunaJTS/integration/src/main/java/com/arjuna/ats/jbossatx/jta/TransactionManagerService.java
I have looked at these remaining deprecations and they appear to be OK, certainly they are not ones that refer to tests.
                
> Restore commit method to AtomicAction
> -------------------------------------
>
>                 Key: JBTM-1430
>                 URL: https://issues.jboss.org/browse/JBTM-1430
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Transaction Core
>    Affects Versions: 4.17.3
>            Reporter: Mark Little
>            Assignee: Tom Jenkinson
>
> At some point someone deprecated the commit method in AtomicAction and left the following comment:
> @deprecated Only used by tests
> This is wrong. Just because we don't use the commit method in the code does not mean it is invalid in the scope of the public API. The commit method without the boolean parameter is a helper method to simplify calling the other commit with true all of the time. This was added years ago based on feedback from the OTS Current implementation, which had (in C++) a default boolean=true parameter in its signature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira