[jbossts-issues] [JBoss JIRA] (JBTM-1764) REST-AT coordinator does not handle commit correctly for transactions marked rollback only

[Michael Musgrove (JIRA)]

     [ https://issues.jboss.org/browse/JBTM-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Musgrove updated JBTM-1764:
-----------------------------------

        Status: Resolved  (was: Pull Request Sent)
    Resolution: Done


When committing a transaction the spec says
{quote} 
325The state of the transaction MUST be TransactionActive for this operation to succeed
{quote}

Although it is not explicitly stated what should happen if the state is TransactionRollbackOnly, I think it is reasonably clear the intent is to rollback such a transaction in this state and therefore the fix allows the transaction to proceed to rollback when asked to commit in this state. We'll update the spec to clarify the intent.

Note that there is a similar check which refuses participant enlistment in a transaction that is marked rollback only. This is in compliance with the spec:
{quote}
385If the transaction is not TransactionActive when registration is attempted, then the implementation
386MUST return a 412 status code.
{quote}

and is reasonable so I still refuse the enlistment when the transaction is in this state. Note that a "participant" can still take part in Volatile phase of the protocol (cf Synchronizations) to discover the outcome of a transaction even if it has been marked rollback only.

                
> REST-AT coordinator does not handle commit correctly for transactions marked rollback only
> ------------------------------------------------------------------------------------------
>
>                 Key: JBTM-1764
>                 URL: https://issues.jboss.org/browse/JBTM-1764
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: REST
>    Affects Versions: 5.0.0.M3
>            Reporter: Michael Musgrove
>            Assignee: Michael Musgrove
>             Fix For: 5.0.0.M4
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> The REST-AT coordinator does not automatically roll back a transaction marked  TransactionRollbackOnly if asked to commit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira