[jbossts-issues] [JBoss JIRA] (JBTM-1712) perf problem in FileSystemStore.openAndLock

Jonathan Halliday (JIRA) jira-events at lists.jboss.org
Fri May 24 09:18:06 EDT 2013


Jonathan Halliday created JBTM-1712:
---------------------------------------

             Summary: perf problem in FileSystemStore.openAndLock
                 Key: JBTM-1712
                 URL: https://issues.jboss.org/browse/JBTM-1712
             Project: JBoss Transaction Manager
          Issue Type: Enhancement
      Security Level: Public (Everyone can see)
          Components: Transaction Core
    Affects Versions: 4.16.4
            Reporter: Jonathan Halliday
            Assignee: Tom Jenkinson


if(!file.exits())
{
   if(createHierarchy(file))

incorrectly calls the expensive (because synchronized) createHierarchy method in the common case where the file does not exist (because it's a uniq named new tx record) but the directory hierarchy does (because it's the create-once hashed dir tree).  This causes excessive contention on the FileSystemStore instance object monitor lock.  Should probably be something more like 

if(!file.getParent().exists())
{
  if(createHierarchy(file))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbossts-issues mailing list