[jbossts-issues] [JBoss JIRA] (JBTM-1712) perf problem in FileSystemStore.openAndLock
RH Bugzilla Integration (JIRA)
jira-events at lists.jboss.org
Tue May 28 23:09:54 EDT 2013
[ https://issues.jboss.org/browse/JBTM-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777664#comment-12777664 ]
RH Bugzilla Integration commented on JBTM-1712:
-----------------------------------------------
James Livingston <jlivings at redhat.com> made a comment on [bug 968125|https://bugzilla.redhat.com/show_bug.cgi?id=968125]
The transaction manager may perform expensive work which has no effect when the log file does not exist but the hierarchy does.
The fix is at https://source.jboss.org/changelog/Narayana?cs=327461a3a8dae50e6621c0a560807bd482d26c3d and should be able to be easily backported
> perf problem in FileSystemStore.openAndLock
> -------------------------------------------
>
> Key: JBTM-1712
> URL: https://issues.jboss.org/browse/JBTM-1712
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Transaction Core
> Affects Versions: 4.16.4, 5.0.0.M2
> Reporter: Jonathan Halliday
> Assignee: Mark Little
> Fix For: 5.0.0.M3
>
>
> if(!file.exits())
> {
> if(createHierarchy(file))
> incorrectly calls the expensive (because synchronized) createHierarchy method in the common case where the file does not exist (because it's a uniq named new tx record) but the directory hierarchy does (because it's the create-once hashed dir tree). This causes excessive contention on the FileSystemStore instance object monitor lock. Should probably be something more like
> if(!file.getParent().exists())
> {
> if(createHierarchy(file))
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbossts-issues
mailing list