[jbossts-issues] [JBoss JIRA] (JBTM-2279) Provide a way to allow overriding of a set CheckedActionFactory

[Mark Little (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018910#comment-13018910 ] 

Mark Little edited comment on JBTM-2279 at 11/11/14 8:14 AM:
-------------------------------------------------------------

Wouldn't it have been easier/better/less invasive to have hidden this within a call to something like getCheckedActionFactory()?

_checkedAction = _checkedActionFactory.getCheckedAction(get_uid(), type());
+		_checkedAction = allowCheckedActionFactoryToBeOverriden ? arjPropertyManager
+				.getCoordinatorEnvironmentBean().getCheckedActionFactory()
+				.getCheckedAction(get_uid(), type())
+				: defaultCheckedActionFactory.getCheckedAction(get_uid(),
+						type());


was (Author: marklittle):
Wouldn't it have been easier/better/less invasive to have hidden this within the call to getCheckedAction?

_checkedAction = _checkedActionFactory.getCheckedAction(get_uid(), type());
+		_checkedAction = allowCheckedActionFactoryToBeOverriden ? arjPropertyManager
+				.getCoordinatorEnvironmentBean().getCheckedActionFactory()
+				.getCheckedAction(get_uid(), type())
+				: defaultCheckedActionFactory.getCheckedAction(get_uid(),
+						type());

> Provide a way to allow overriding of a set CheckedActionFactory
> ---------------------------------------------------------------
>
>                 Key: JBTM-2279
>                 URL: https://issues.jboss.org/browse/JBTM-2279
>             Project: JBoss Transaction Manager
>          Issue Type: Enhancement
>          Components: Transaction Core
>            Reporter: Tom Jenkinson
>            Assignee: Tom Jenkinson
>             Fix For: 5.0.4
>
>
> Out of the box the BasicAction caches the reference to the checkedactionfactory and so if a users classpath is not available to narayana there is no way for a user to provide a CAF to Narayana.



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)