[jbossts-issues] [JBoss JIRA] (JBTM-2284) XID.toString broken: indexing mistake in array

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019252#comment-13019252 ] 

Tom Jenkinson commented on JBTM-2284:
-------------------------------------

My apologies, it looks like we forgot to backport the fix for this useful bugfix. I have done that now.

Fix on master: https://github.com/jbosstm/narayana/commit/6e8435a3175f6bc583b3af71c58def4f5f6b99b3
Fix on 4.17: https://github.com/jbosstm/narayana/commit/23a72786efacd3ee0a5889c7f25f51b1128ec952

> XID.toString broken: indexing mistake in array
> ----------------------------------------------
>
>                 Key: JBTM-2284
>                 URL: https://issues.jboss.org/browse/JBTM-2284
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>    Affects Versions: 4.17.15
>         Environment: EAP 6.2.4 with JBoss JTS module in version 4.17.15
>            Reporter: Christian von Kutzleben
>            Assignee: Tom Jenkinson
>             Fix For: 4.17.24
>
>
> com.arjuna.ats.internal.jta.xa.XID	
> 	
> 	public String toString ()
> 	{        
>         //...
>                 stringBuilder.append(", ");
>         for (int i = 0; i < bqual_length; i++) {
>             stringBuilder.append(gtrid_length+data[i]);
>         }        
>         //...
>     }
>     
> correct: stringBuilder.append(data[i+gtrid_length]);
> The result is, that the Xid instances logged in log files are corrupted and multiple different Xid share the same String representation, which makes the logging information unusable



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)