[jbossts-issues] [JBoss JIRA] (JBTM-2291) ObjStoreBrowser can return stale Uid if the machine is very fast or the machines clock has a low fidelity

[Tom Jenkinson (JIRA)]

     [ https://issues.jboss.org/browse/JBTM-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Jenkinson updated JBTM-2291:
--------------------------------
        Status: Resolved  (was: Pull Request Sent)
    Resolution: Done


As this is usually done in real time I have opted to implement this with nano time. If the clock never moves on for example it would still mean a probe,del,probe sequence may return stale values but as this is not likely in normal operation and data integrity is not affected I have resolved the issue. It may be beneficial to attempt to alter the code to not use the time at all but this would be a low priority issue as it should really only affect test verification steps on very fast machines now.

> ObjStoreBrowser can return stale Uid if the machine is very fast or the machines clock has a low fidelity
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JBTM-2291
>                 URL: https://issues.jboss.org/browse/JBTM-2291
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>          Components: Tooling
>            Reporter: Tom Jenkinson
>            Assignee: Michael Musgrove
>             Fix For: 5.0.4
>
>
> ObjStoreBrowser::probe uses System.currentTimeMillis to determine whether its list of allUids contains stale date during updateMBeans call.
> Now if you imagine a clock which never moved on (low fidelity) then this would mean that a Uid was never eligible to be reaper from this list.
> Or imagine a machine that is very fast (my laptop for example) and it is possible that probe, remove entry, probe can all be called in the same millisecond.



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)