[jbossts-issues] [JBoss JIRA] (JBTM-2573) Can not set the right jbossts properties file when running the commitmarkable test under the codeCoverage

Amos Feng (JIRA) issues at jboss.org
Tue Dec 8 10:01:00 EST 2015

     [ https://issues.jboss.org/browse/JBTM-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amos Feng updated JBTM-2573:
        Status: Resolved  (was: Pull Request Sent)
    Resolution: Done

> Can not set the right jbossts properties file when running the commitmarkable test under the codeCoverage
> ---------------------------------------------------------------------------------------------------------
>                 Key: JBTM-2573
>                 URL: https://issues.jboss.org/browse/JBTM-2573
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Amos Feng
>            Assignee: Amos Feng
>             Fix For: 5.next
> currently the ArjunaJTA/jta commitmarkable tests fails when running under the codeCoverage. The root cause is that the jbossts properties file does not set to the "commitmarkableresourcejbossts-properties.xml".
> The surefire-plugin config the system property com.arjuna.ats.arjuna.common.propertiesFile with "jbossts-properties.xml" in the codeCoverage profile
> https://github.com/jbosstm/narayana/blob/master/pom.xml#L645
> So the https://github.com/jbosstm/narayana/blob/master/ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/commitmarkable/TestCommitMarkableResourceBase.java#L64
> {code}
> resetPropertiesFile = System
> 	.getProperty("com.arjuna.ats.arjuna.common.propertiesFile");
> if (resetPropertiesFile == null) {
> 	System.setProperty("com.arjuna.ats.arjuna.common.propertiesFile",
> 		"commitmarkableresourcejbossts-properties.xml");
> }
> {code}
> the resetPropertiesFile does not be null and the if check statement is false, so the System.setProperty(...) can not run and the property is still the jbossts-properties.xml.
> the resetPropertiesFile could be used to revert to the origin value in the tearDown()
> https://github.com/jbosstm/narayana/blob/master/ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/commitmarkable/TestCommitMarkableResourceBase.java#L79
> {code}
> if (resetPropertiesFile != null) {
> 	System.setProperty("com.arjuna.ats.arjuna.common.propertiesFile",
> 		resetPropertiesFile);
> } else {
> 	System.clearProperty("com.arjuna.ats.arjuna.common.propertiesFile");
> }
> {code}
> This failure does not happen in the default profile as the surefire-plugin does not set this system property in the profile.

This message was sent by Atlassian JIRA

More information about the jbossts-issues mailing list