[jbossts-issues] [JBoss JIRA] (JBTM-2206) Use synchronized HashMaps

[Michael Musgrove (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051451#comment-13051451 ] 

Michael Musgrove edited comment on JBTM-2206 at 3/18/15 11:57 AM:
------------------------------------------------------------------

Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitious/unambitious, Tom suggests 0.5%.

It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR).

The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. 


was (Author: mmusgrov):
Yes, we will only make the change if we can demonstrate a benefit. That said, the current criteria for a performance improvement/degradation is 10% better/worse, respectively, which may be too ambitiou/unambitious, Tom suggests 0.5%.

It is also possible that the benchmarks that the PR job runs will not exercise the code changes so it may be necessary for new benchmarks to be added (by us or by whoever raises the PR).

The article Tom mentioned will give a fuller description of what and how we benchmark and the criteria for pass/failure. 

> Use synchronized HashMaps
> -------------------------
>
>                 Key: JBTM-2206
>                 URL: https://issues.jboss.org/browse/JBTM-2206
>             Project: JBoss Transaction Manager
>          Issue Type: Sub-task
>          Components: Transaction Core
>            Reporter: Jesper Pedersen
>            Assignee: Michael Musgrove
>
> Change usage of Hashtable into synchronized HashMap's instead.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)