[jbossts-issues] [JBoss JIRA] (JBTM-2656) XATerminatorImple#recover should return an empty array in preference to null

[Tom Jenkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195366#comment-13195366 ] 

Tom Jenkinson commented on JBTM-2656:
-------------------------------------

By returning null we are returning zero Xids, I am inclined to say we are therefore compliant. That said a zero sized array would simplify our own testing to I am receptive to the change but not under compliance arguments - hence downgrading to Minor.

> XATerminatorImple#recover should return an empty array in preference to null
> ----------------------------------------------------------------------------
>
>                 Key: JBTM-2656
>                 URL: https://issues.jboss.org/browse/JBTM-2656
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>          Components: JCA
>    Affects Versions: 5.3.2.Final
>            Reporter: Michael Musgrove
>            Assignee: Michael Musgrove
>             Fix For: 5.next
>
>
> The javadoc (http://docs.oracle.com/javaee/7/api/javax/resource/spi/XATerminator.html#recover-int-) for the XATerminator recover 
> method says the resource manager should return zero or more XIDs or throw an exception but our implementation of it returns null if there are no in doubt Xids.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)