[jbossts-issues] [JBoss JIRA] (JBTM-2812) Calling forget on an XAResource should always remove the corresponding log

[Michael Musgrove (JIRA)]

Michael Musgrove created JBTM-2812:
--------------------------------------

             Summary: Calling forget on an XAResource should always remove the corresponding log
                 Key: JBTM-2812
                 URL: https://issues.jboss.org/browse/JBTM-2812
             Project: JBoss Transaction Manager
          Issue Type: Bug
          Components: JTA
    Affects Versions: 5.4.0.Final
            Reporter: Michael Musgrove
            Assignee: Michael Musgrove
             Fix For: 5.next


During abort processing (in BasicAction) we attempt to forgetHeuristics and then remove the participant log. The fix for JBTM-2728 changed this behaviour such that the log is retained if the resource forget operation fails. This is a change in behaviour and needs to be reverted.

Note that the resource will still eventually be told to forget during normal recovery processing for orphans (provided we have configured presumed abort semantics):

# our XARecoveryModule asks the resource for its pending branches (via the xa_recover() peration);
# if the xid is one of ours and if we no longer have a record for it then we call rollback on it presumed abort);
# the reosource uses the rollback call to tell us that the branch was already heuristically rolled back so we call forget



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)