[jbossts-issues] [JBoss JIRA] (JBTM-3162) Remove superfluous double check at validTransaction method

[Anonymous (Jira)]

     [ https://issues.jboss.org/browse/JBTM-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Issue was automatically transitioned when Ariel Carrera created pull request #1467 in GitHub
--------------------------------------------------------------------------------------------
    Status: Pull Request Sent  (was: Open)


> Remove superfluous double check at validTransaction method
> ----------------------------------------------------------
>
>                 Key: JBTM-3162
>                 URL: https://issues.jboss.org/browse/JBTM-3162
>             Project: JBoss Transaction Manager
>          Issue Type: Enhancement
>          Components: Transactional Driver
>    Affects Versions: 5.9.5.Final
>            Reporter: Ariel Carrera
>            Priority: Trivial
>
> There is a superfluous check at BaseTransactionalDriverXAConnection.validTransaction method.
> {code:java}
>     public final boolean validTransaction(javax.transaction.Transaction tx) {  
>         boolean valid = true;  
>         if (_theTransaction != null) {  
>             valid = _theTransaction.equals(tx);  
> *            if (!valid) {  
>                 valid = _theTransaction.equals(tx);  
>             }  *
>         }  
>         return valid;  
>     }  
> {code}
> link:
> [github|https://github.com/jbosstm/narayana/blob/9f42d45b664483c9f0e17cb20122c1d5436ba856/ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/BaseTransactionalDriverXAConnection.java#L81]



--
This message was sent by Atlassian Jira
(v7.12.1#712002)