[jbossts-issues] [JBoss JIRA] (JBTM-3163) AfterLRA notifications are delivered twice

[Michael Musgrove (Jira)]

    [ https://issues.jboss.org/browse/JBTM-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764084#comment-13764084 ] 

Michael Musgrove commented on JBTM-3163:
----------------------------------------

bq. The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished 

Doesn't this mean the test is wrong (or the spec is wrong for not being explicit here). The semantics are "at least once" so multiple attempts to deliver the notification should be allowed since delivery is not always guaranteed in an HTTP environment.

We can fix the code so that it only delivers the notification once on each recovery pass but it is not Major priority.

> AfterLRA notifications are delivered twice
> ------------------------------------------
>
>                 Key: JBTM-3163
>                 URL: https://issues.jboss.org/browse/JBTM-3163
>             Project: JBoss Transaction Manager
>          Issue Type: Task
>          Components: LRA
>    Affects Versions: 5.9.5.Final
>            Reporter: Martin Stefanko
>            Assignee: Martin Stefanko
>            Priority: Major
>   Original Estimate: 1 hour
>          Time Spent: 1 hour
>  Remaining Estimate: 0 minutes
>
> @AfterLRA notifications recently introduced in the specification are being delivered twice when the LRA is finished.
> There is actually a TCK test testing this for non JAX-RS participant so this is blocking [PR 1450|https://github.com/jbosstm/narayana/pull/1450].
> The failing TCK test `TckParticipantTests#validWebApplicationExceptionReturnedTest` asserts now that `@AfterLRA` method is called once after the LRA is finished - https://github.com/eclipse/microprofile-lra/blob/master/tck/src/main/java/org/eclipse/microprofile/lra/tck/TckParticipantTests.java#L82. This means that the specification prohibits that AfterLRA method is called more than once for one LRA.
> This isn't failing current TCK as the assert is present in the non-JAX-RS TCK ([PR 1450|https://github.com/jbosstm/narayana/pull/1450])



--
This message was sent by Atlassian Jira
(v7.12.1#712002)