[jbossws-commits] JBossWS SVN: r2632 - trunk/jbossws-core/src/java/org/jboss/ws/core/soap.

[jbossws-commits at lists.jboss.org]

Author: jason.greene at jboss.com
Date: 2007-03-16 16:40:00 -0400 (Fri, 16 Mar 2007)
New Revision: 2632

Modified:
   trunk/jbossws-core/src/java/org/jboss/ws/core/soap/SOAPBodyImpl.java
Log:
Revert hasFault change that was included in 2629
(It introduced severe TCK regression)

Modified: trunk/jbossws-core/src/java/org/jboss/ws/core/soap/SOAPBodyImpl.java
===================================================================
--- trunk/jbossws-core/src/java/org/jboss/ws/core/soap/SOAPBodyImpl.java	2007-03-16 19:18:35 UTC (rev 2631)
+++ trunk/jbossws-core/src/java/org/jboss/ws/core/soap/SOAPBodyImpl.java	2007-03-16 20:40:00 UTC (rev 2632)
@@ -79,7 +79,6 @@
    private Source payload;
    private boolean isDOMValid = true;
    private boolean isModifiedFromSource;
-   private boolean hasFault;
 
    public SOAPBodyImpl(String prefix, String namespace)
    {
@@ -157,7 +156,6 @@
       SOAPFaultImpl soapFault = new SOAPFaultImpl(getPrefix(), getNamespaceURI());
       soapFault = (SOAPFaultImpl)addChildElement(soapFault);
       soapFault.setFaultCode(soapFault.getDefaultFaultCode());
-      hasFault = true;
       return soapFault;
    }
 
@@ -172,7 +170,6 @@
       soapFault = (SOAPFaultImpl)addChildElement(soapFault);
       soapFault.setFaultCode(faultCode);
       soapFault.setFaultString(faultString);
-      hasFault = true;
       return soapFault;
    }
 
@@ -187,7 +184,6 @@
       soapFault = (SOAPFaultImpl)addChildElement(soapFault);
       soapFault.setFaultCode(faultCode);
       soapFault.setFaultString(faultString);
-      hasFault = true;
       return soapFault;
    }
 
@@ -202,7 +198,6 @@
       soapFault.setFaultCode(faultCode);
       soapFault.setFaultString(faultString, locale);
       addChildElement(soapFault);
-      hasFault = true;
       return soapFault;
    }
 
@@ -217,7 +212,6 @@
       soapFault.setFaultCode(faultCode);
       soapFault.setFaultString(faultString, locale);
       addChildElement(soapFault);
-      hasFault = true;
       return soapFault;
    }
 
@@ -227,14 +221,13 @@
       expandToDOM(true);
       Iterator it = faultIterator();
       SOAPFault soapFault = it.hasNext() ? (SOAPFault)it.next() : null;
-      hasFault = (soapFault != null);
       return soapFault;
    }
 
    public boolean hasFault()
    {
       log.trace("hasFault");
-      return hasFault;
+      return faultIterator().hasNext();
    }
 
    private Iterator faultIterator()