[jbossws-dev] DOMWriter changes

[Thomas Diesler]

Hi Alessio,

the case statement for '\r' seemed to ignore the
canonical flag.

	589	615	 	            case '\r':
	590	 	-	            {
  	591	 	-	               str.append("
");
  	592	 	-	               break;
  	593	 	-	            }
	594	616	 	            case '\n':
  	595	617	 	            {
  	596	618	 	               if (canonical)

If it is needed please add a test for it in the DOMWriterTestCase. Also 
please note there is a copy of this code in jboss-common-core. The 
DOMWriter and its associated tet case should be kept in sync with the 
jboss-common-core.

Ideally jbossws would not contain the DOMWriter/DOMUtils at all.

Sorry, for not pinging you about this directly, but good that the 
jbossws test case picked up the change at all.

cheers
-thomas



Alessio Soldano wrote:
> Hi Thomas,
> I think this change 
> http://fisheye.jboss.com/browse/JBossWS/common/trunk/src/main/java/org/jboss/wsf/common/DOMWriter.java?r1=7980&r2=7982 
> is the cause of the regression in SimpleSignTestCase 
> (http://jbws.dyndns.org:8180/hudson/job/Native-Core-AS-4.2.3/31/testReport/org.jboss.test.ws.jaxws.samples.wssecurity/SimpleSignTestCase/testEndpointWithCRLFs/) 
> we currently have.
> Could you please explain me why removing str.append("
"); is 
> required for your use case? Btw we talked about this topic here: 
> http://www.jboss.com/index.html?module=bb&op=viewtopic&t=130664
> Thank you
> Cheers
> Alessio
> _______________________________________________
> jbossws-dev mailing list
> jbossws-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbossws-dev

-- 
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
BPM Product Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx