[jbossws-dev] [JBWS-CXF] On injections and @PostConstruct

[Sergey Beryozkin]

Hi Richard

thanks for the review. I actually started modifying the CXF code so that a custom ResourceInjector can be injected
but then I thought, given that ResourceInjector is a concrete class and its initialization is a bit involved too, we'd need
to have more complex requirements (compared to just blocking/postponing a PostConstruct call) for us to start overriding ResourceInjector. The code can be enhanced when needed...

cheers, Sergey  

> Hi Sergey,
> 
>     I reviewed your patches on both CXF and JBoss side.
> IMO it's sufficient for now how you prototyped it ;)
> 
> Rio
> 
> On 07/08/2010 06:06 PM, Sergey Beryozkin wrote:
> > Hi
> >
> >    
> >> After doing the initial investigation, it seems to me that
> introducing
> >> a 'blockPostConstruct' property into
> >> JaxWsServerFactoryBean can make the trick. Another update which is
> >> needed is adding a protected JAXWSServerFactoryBean getter to CXF
> >> EndpointImpl so that a JBoss CXF EmdpointImpl can set a
> >> blockPostConstruct property to true thus not requiring overriding
> >> JAXWSServerFactoryBean and injecting it into CXF EndpointImpl;
> >>      
> > I attached a patch to the JBWS-3001 JIRA :
> https://jira.jboss.org/browse/JBWS-3001,
> > it can be applied once CXF 2.2.10 gets released, see
> http://svn.apache.org/viewvc?rev=961823&view=rev.
> > The framework JBWS-2068 test passes if JBossCXF depends on the
> modified CXF 2.2.10 snapshot.
> >
> >
> >    
> >> I'll also enable the injection of a custom ResourceInjector
> >>
> >>      
> > I actually stopped short of doing it - I though being able to
> disable calling a PostConstruct method by setting a  property
> > might be simpler...The code may be further modified if we really
> need to be able to injected custom ResourceInjectors
> >
> > Let me know please if you have any doubts
> >
> >    
> >> cheers, Sergey
> >>
> >>      
> > _______________________________________________
> > jbossws-dev mailing list
> > jbossws-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/jbossws-dev
> >    
> 
> 
> -- 
> Richard Opalka
> ropalka at redhat.com
> JBoss, by Red Hat
> 
> Office: +420 222 365 200
> Mobile: +420 731 186 942
> 
> _______________________________________________
> jbossws-dev mailing list
> jbossws-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbossws-dev