[jbossws-issues] [JBoss JIRA] Commented: (JBWS-1819) wsrunclient script(s) differ and do not always function.

[Heiko Braun (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBWS-1819?page=comments#action_12381443 ] 
            
Heiko Braun commented on JBWS-1819:
-----------------------------------

The only real difference I see is that you added xerces to the classpath and changed to quotes in the eval command. What exception did you see without xerces in the CP? Furthermore the quotes seem to be right for me. Don't get me wrong, I appreciate your contribution, but cannot see the issue it solves unless you supply a stacktrace or description of the errors you've been encountering.

> wsrunclient script(s) differ and do not always function.
> --------------------------------------------------------
>
>                 Key: JBWS-1819
>                 URL: http://jira.jboss.com/jira/browse/JBWS-1819
>             Project: JBoss Web Services
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: productization
>    Affects Versions: jbossws-2.0.1
>         Environment: Windows-XP including Cygwin.
>            Reporter: Tom Uijldert
>         Assigned To: Heiko Braun
>            Priority: Minor
>             Fix For:  jbossws-2.0.2
>
>         Attachments: wsrunclient.sh.diff
>
>   Original Estimate: 1 day
>  Remaining Estimate: 1 day
>
> Scripts wsrunclient.sh and wsrunclient.bat contain some questionable code:
> 1. They both define a "-Djava.endorsed.dirs" that is only used by javac. The compiler is not called here, only the  JVM. The JVM doesn't seem to use it...
> 2. The included classpaths in the batch- and shell-file differ wildly. This cannot be attributed to OS-differences. I keep wondering what jars are actually needed...
> 3. The 'eval ...' command in wsrunclient.sh mis-quotes the actual command and at least 1 jar is missing.
> Below a "diff -u" on the shell-script. Changes that were needed to get it running in my environment.
> Hope this helps,
> Tom.
> the diff:
> ----------
> --- ../../jbossws-native-2.0.1.GA/bin/wsrunclient.sh	2007-08-17 18:58:06.000000000 +0200
> +++ ../../jboss-4.2.1.GA/bin/wsrunclient.sh.new	2007-09-21 13:53:59.638125000 +0200
> @@ -52,9 +52,6 @@
>  # Setup JBoss sepecific properties
>  JAVA_OPTS="$JAVA_OPTS"
>  
> -# Setup the java endorsed dirs
> -JBOSS_ENDORSED_DIRS="$JBOSS_HOME/lib/endorsed"
> -
>  # Setup the client classpath
>  WSRUNCLIENT_CLASSPATH="$WSRUNCLIENT_CLASSPATH:$JBOSS_HOME/client/log4j.jar"
>  WSRUNCLIENT_CLASSPATH="$WSRUNCLIENT_CLASSPATH:$JBOSS_HOME/client/jbossws-client.jar"
> @@ -66,6 +63,8 @@
>  # JBossAS-4.2 subset of jbossall-client.jar
>  WSRUNCLIENT_CLASSPATH="$WSRUNCLIENT_CLASSPATH:$JBOSS_HOME/client/jboss-common-client.jar"
>  
> +WSRUNCLIENT_CLASSPATH="$WSRUNCLIENT_CLASSPATH:$JBOSS_HOME/lib/endorsed/xercesImpl.jar"
> +
>  while [ $# -ge 1 ]; do
>     case $1 in
>         "-classpath") WSRUNCLIENT_CLASSPATH="$WSRUNCLIENT_CLASSPATH:$2"; shift;;
> @@ -82,9 +81,7 @@
>      JBOSS_ENDORSED_DIRS=`cygpath --path --windows "$JBOSS_ENDORSED_DIRS"`
>  fi
>  
> -# Execute the JVM
>  eval "$JAVA" $JAVA_OPTS \
> -   -Djava.endorsed.dirs="$JBOSS_ENDORSED_DIRS" \
>     -Dlog4j.configuration=wstools-log4j.xml \
> -   -classpath "$WSRUNCLIENT_CLASSPATH" \
> +   -classpath '$WSRUNCLIENT_CLASSPATH' \
>     "$args"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira