[jbossws-issues] [JBoss JIRA] Reopened: (JBWS-1763) Incorrect handling of charsets when the default charset is not UTF-8

[Richard Opalka (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBWS-1763?page=all ]

Richard Opalka reopened JBWS-1763:
----------------------------------

             
[/home/opalka][/home/opalka/svn/jbossws/stack/native/trunk/src/main/java/org/jboss/ws/core/binding]>svn log --limit 2 BufferedStreamResult.java 
------------------------------------------------------------------------
r4379 | darran.lofthouse at jboss.com | 2007-08-15 17:43:12 +0200 (Wed, 15 Aug 2007) | 1 line

[JBWS-1453] - WSDL To Java - Invalid name for generated class if complex type name contains a period.
------------------------------------------------------------------------
r4323 | darran.lofthouse at jboss.com | 2007-08-10 18:29:39 +0200 (Fri, 10 Aug 2007) | 1 line

[JBWS-1763] - Incorrect handling of charsets when the default charset is not UTF-8.
------------------------------------------------------------------------
[/home/opalka][/home/opalka/svn/jbossws/stack/native/trunk/src/main/java/org/jboss/ws/core/binding]>svn diff -r4323:4279 BufferedStreamResult.java 
Index: BufferedStreamResult.java
===================================================================
--- BufferedStreamResult.java   (revision 4323)
+++ BufferedStreamResult.java   (revision 4279)
@@ -27,7 +27,6 @@
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
-import java.io.UnsupportedEncodingException;
 import java.io.Writer;
 
 import javax.xml.transform.stream.StreamResult;
@@ -52,7 +51,7 @@
    {
       try
       {
-         IOUtils.copyStream(getOutputStream(), new ByteArrayInputStream(xmlFragment.getBytes("UTF-8")));
+         IOUtils.copyStream(getOutputStream(), new ByteArrayInputStream(xmlFragment.getBytes()));
       }
       catch (IOException e)
       {
@@ -86,16 +85,6 @@
 
    public String toString()
    {
-      String result = null;
-      try
-      {
-         result = baos.toString("UTF-8");
-      }
-      catch (UnsupportedEncodingException e)
-      {
-         WSException.rethrow(e);
-      }
-
-      return result;
+      return baos.toString();
    }
 }


> Incorrect handling of charsets when the default charset is not UTF-8
> --------------------------------------------------------------------
>
>                 Key: JBWS-1763
>                 URL: http://jira.jboss.com/jira/browse/JBWS-1763
>             Project: JBoss Web Services
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: jbossws-1.2.0.SP1
>            Reporter: Darran Lofthouse
>         Assigned To: Darran Lofthouse
>             Fix For: jbossws-native-2.0.4
>
>
> There are a number of places that the default charset is used  when converting to and from byte arrays that require UTF-8 encoding.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira