[jbossws-issues] [JBoss JIRA] Created: (JBWS-2395) Maven Refactoring Damaged Many wstools tests

[Darran Lofthouse (JIRA)]

Maven Refactoring Damaged Many wstools tests
--------------------------------------------

                 Key: JBWS-2395
                 URL: https://jira.jboss.org/jira/browse/JBWS-2395
             Project: JBoss Web Services
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: tools-jaxrpc
    Affects Versions: jbossws-native-3.0.4
            Reporter: Darran Lofthouse
            Assignee: Darran Lofthouse
            Priority: Critical
             Fix For: jbossws-native-3.0.5


Previously many of the tests in the package 'org.jboss.test.ws.tools' used the following two variables: -

      String resourceDir = "resources/tools/jbws1079";
      String toolsDir = "tools/jbws1079";

The 'resourcesDir' is where the base source and descriptors live as the expected results of the test, the 'toolsDir' is where the new source is generated when the test runs.

After the maven refactoring we have: -

      File resourceFile = createResourceFile("tools/jbws1079");
      String resourceDir = resourceFile.getAbsolutePath();
      String toolsDir = resourceDir;

The resourceDir and toolsDir are now the same.

This is not a problem for the source code as the expected source is not in a package structure whilst the generated code is so these do not conflict.

However for the comparison of the mapping files: -

  mappingValidator.validate(resourceDir + "/anonymous-mapping.xml", toolsDir + "/anonymous-mapping.xml");

We end up checking if a file is identical to itself which of course passes.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira