[jbossws-issues] [JBoss JIRA] Created: (JBWS-2899) Remove WSAspectizedDeployersFactory from stack specific configs

[Richard Opalka (JIRA)]

Remove WSAspectizedDeployersFactory from stack specific configs
---------------------------------------------------------------

                 Key: JBWS-2899
                 URL: https://jira.jboss.org/jira/browse/JBWS-2899
             Project: JBoss Web Services
          Issue Type: Sub-task
      Security Level: Public (Everyone can see)
          Components: jbossws-cxf, jbossws-integration, jbossws-jaxrpc, jbossws-metro, jbossws-native
            Reporter: Richard Opalka
            Assignee: Alessio Soldano


The following commit breaks AS IL abstraction and since now all stacks are using it directly not via SPI:

On 01/25/2010 11:21 AM, jbossws-commits at lists.jboss.org wrote:
> Author: alessio.soldano at jboss.com
> Date: 2010-01-25 05:21:43 -0500 (Mon, 25 Jan 2010)
> New Revision: 11480
>
> Modified:
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/ws/extensions/wsrm/server/RMDeploymentAspect.java
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/EagerInitializeDeploymentAspect.java
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/EventingDeploymentAspect.java
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/PublishContractDeploymentAspect.java
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/ServiceEndpointInvokerDeploymentAspect.java
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/java/org/jboss/wsf/stack/jbws/UnifiedMetaDataDeploymentAspect.java
>    stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml
> Log:
> Using new AbstractDeploymentAspect + moving WSAspectizedDeployerFactory to stack specific config file
>
> Modified: stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml
> ===================================================================
> --- stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml	2010-01-25 10:15:58 UTC (rev 11479)
> +++ stack/native/branches/jaxrpc-cxf/modules/core/src/main/resources/jbossws-native-config-as6.xml	2010-01-25 10:21:43 UTC (rev 11480)
> @@ -2,6 +2,17 @@
>  
>  <deployment xmlns="urn:jboss:bean-deployer:2.0">
>  
> +  <!-- WSDeploymentAspectDeployers factory -->
> +  <bean name="WSAspectizedDeployersFactory" class="org.jboss.webservices.integration.deployers.WSAspectizedDeployersFactory">
> +    <constructor>
> +      <parameter>
> +        <inject bean="Deployers"/>
> +      </parameter>
> +    </constructor>
> +    <incallback method="addDeployer"/>
> +    <uncallback method="removeDeployer"/>
> +  </bean>
> +
>    <!-- The registry for web service endpoints -->
>    <bean name="WSEndpointRegistry" class="org.jboss.wsf.framework.management.ManagedEndpointRegistry">
>      <property name="mbeanServer"><inject bean="WSMBeanServerLocator" property="mbeanServer"/></property>
>
> _______________________________________________
> jbossws-commits mailing list
> jbossws-commits at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbossws-commits

I know this is just a prototype ATM but before before merging to trunks it should be fixed.
AFAIR it is somehow related to the class loaders hack in WSDeploymentAspectDeployer.

I suggest the following solution instead of the aforementioned one:

 * move WSAspectizedDeployersFactory back to stack-agnostic-jboss-beans.xml
 * in WSDeploymentAspectDeployer.internalUn/Deploy() methods do:

final ClassLoader oldCL = Thread.currentThread().getContextClassLoader();  // TODO: protect with security actions helper class
final ClassLoader newCL = this.aspect.getClass().getClassLoader();
try {
   Thread.currentThread().setContextClassLoader(newCL); // TODO: protect with security actions helper class
   this.aspect.start(dep);
} finally {
   Thread.currentThread.setContextClassLoader(oldCL);  // TODO: protect with security actions helper class
}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira