[jbossws-issues] [JBoss JIRA] (JBWS-3573) Review Coverity reports for JBossWS projects

[Alessio Soldano (JIRA)]

    [ https://issues.jboss.org/browse/JBWS-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742385#comment-12742385 ] 

Alessio Soldano commented on JBWS-3573:
---------------------------------------

10227: serviceClass can't be null because serviceImplClass can't be null too, so this is not a bug
10083: no need for doing anything, the ByteArrayOutputStream does not leak anything (the same for LoadingByteArrayOutputStream)
10082: fixed
10081: fixed
10080: should be fixed, both the the former and the new way of getting the bus are safe though, if the bus is not there, we'd have failures/exception way before reaching this point
10070: fine like this; adjustMethodAndParams does not always dereference 'params', and I'm not going to duplicate the checks in it (apache cxf) in jbws for the sake of preventing the report entry here only ;-)
10067: fine like this, if the tmp file can't be deleted, it will stay there; the system temp dir should still be cleaned from time to time and marking that file to be deleted on jvm stop (deleteOnExit()) would be pretty much the same as a memory leak
10066: fixed
10063: fixed
10064: fixed
10065: fixed

10072/10076: I'm leaving these to Richard, I believe he has been look at them this morning..
                
> Review Coverity reports for JBossWS projects
> --------------------------------------------
>
>                 Key: JBWS-3573
>                 URL: https://issues.jboss.org/browse/JBWS-3573
>             Project: JBoss Web Services
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: productization
>            Reporter: Rostislav Svoboda
>            Assignee: Alessio Soldano
>             Fix For: jbossws-cxf-4.1.1, jbossws-native-4.1.1
>
>
> http://station5.brq.redhat.com:8080
> Analyzed trunks for:
> * JBossWS API
> * JBossWS SPI
> * JBossWS Common
> * JBossWS Common Tools
> * JBossWS CXF
> * JBossWS Native

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira